search

moogar0880 / PyTrakt

A Pythonic interface to the Trakt.tv REST API
Other
66 stars 51 forks source link

[python-pytrakt] Add show_id attribute to TVEpisode found from search #208

Open simonc56 opened 2 years ago

simonc56 commented 2 years ago

Actually, to get the show of a TVEpisode we only have show name (self.show) which is not reliable because some shows have the same name. The show trakt id is more reliable than show name because it is unique. This PR adds show_id attribute to TVEpisode built from search request and uses it in further API requests instead of slug built from show name.

Example : Top Boy and Top Boy 2019 A TVEpisode from Top Boy 2019 uses slug top-boy (made from slugify(self.show) ) instead of top-boy-2019 to fetch data from trakt api. Therefore data received is wrong.

glensc commented 2 years ago

Carried to my fork:

glensc commented 2 years ago

@twolaw please prepend [python-pytrakt] to this pr title, to indicate this pr has been carried. this will help understand the pull request status in this project.