mookid / diffr

Yet another diff highlighting tool
MIT License
575 stars 22 forks source link

README: Extend example git integration to cover interactive add etc. #23

Closed cdoepmann closed 5 years ago

cdoepmann commented 5 years ago

The currently suggested git integration does not activate diffr when using interactive git commands such as the useful git add -p etc.

This change proposes to add diffr not only the pager.* config options, but also to interactive.diffFilter, so diffs are nicely formatted also in these cases.

mookid commented 5 years ago

Looks great! Let me test for a few days to see if I hit some issues similar to https://github.com/so-fancy/diff-so-fancy/issues/35.

cdoepmann commented 5 years ago

Thanks! I think the difference to the diff-so-fancy issue is that I omitted the | less .... If I understand the git man pages correctly (not explicitly stated), the output from interactive.diffFilter may be piped through another pager, contrary to the pager config options. Therefore, I hope to avoid such issues by not piping diffr's output through less. Let's see.

mookid commented 5 years ago

Thanks!