search

mooltipass / android_companion

Repository for the Mini BLE Android companion app
GNU General Public License v3.0
4 stars 5 forks source link

Public Suffix With SubDomain Handling #24

Closed shabbir81 closed 2 years ago

shabbir81 commented 2 years ago

New option added Logic Updated for Public Suffix Logic Added for Public Suffix with SubDomain

limpkin commented 2 years ago

@shabbir81 : warnings during compilation: mooltifill\PublicSuffixManager.kt: (83, 33): 'toLowerCase(): String' is deprecated. Use lowercase() instead. mooltifill\PublicSuffixManager.kt: (83, 72): 'toLowerCase(): String' is deprecated. Use lowercase() instead. mooltifill\PublicSuffixManager.kt: (91, 20): Condition 'strippedTokens.last() != null' is always 'true' mooltifill\PublicSuffixManager.kt: (156, 13): Condition 'result != null' is always 'true'

limpkin commented 2 years ago

@shabbir81 could you update your PR so @mathfactory could review again?

shabbir81 commented 2 years ago

Updated code and new PR opened

Commit Id 9bcd8509800ad004c135b0a81f176a61b175da8a

mathfactory commented 2 years ago

I hope my comments do not sound too "harsh", thank you very much for the constribution! ;) I think best way would be to adapt the SubstitutionPolicy classes to be async/suspend and to pass a context in fun policies(). I can also offer to have a look into this, just give me a hint.