mooltipass / extension

GitHub Repository Dedicated to our Cross Browser Extension
MIT License
9 stars 8 forks source link

Debug logging is enabled in Firefox even when installed from addons.mozilla.org #125

Closed samoverton closed 2 years ago

samoverton commented 2 years ago

The browser Web Console shows all trace-level logging from the extension.

This is supposed to be enabled only if the extension detects that it was not installed from the Chrome Web Store (ie. it is a development build), however the check is not correct for Firefox, which does not contain the update_url field in the manifest.json even when installed through the Firefox extension site, (addons.mozilla.org)

vendor/mooltipass/backend.js:6

var background_debug_msg = (window.chrome && chrome.runtime && !('update_url' in chrome.runtime.getManifest()))? 55 : false;

Expected behavior: installing the extension through official release channels should have debug logging disabled in all browsers.