search

mooltipass / minible

Github repository containing the firmwares running on the Mooltipass Mini BLE
GNU General Public License v3.0
94 stars 20 forks source link

Short password typed on credentials with TOTP when going back one step #393

Closed kbembedded closed 5 months ago

kbembedded commented 1 year ago

Expected behavior

With all some credentials, its possible to type a field, skip a field, and go back a field manually while using the miniBLE scrollwheel and display. It should not cause issues to type, skip, or go back in any amounts.

Actual behavior

If a user uses the miniBLE to manually type a credential, type the name, password, go back and re-type password, the second time the password is typed is only a single character.

I've only observed this with credentials with TOTP and have been unable to reproduce anything similar with the username and password fields only.

Step by step guide to reproduce the problem

Firmware Version

AUX MCU version: 0.73 Main MCU version: .084 Bundle version: 12

Moolticute Version - If Involved

N/A

Operating System

kbembedded commented 1 year ago

In communicating with some folks in the IRC channel, and doing more testing, I've found that not every credential I have with TOTP does this. But ones that reproduce it always do it, and ones that don't never do.

I need to go through all of my credentials and see what of them has TOTP and test all of them to see if I can narrow down a cause.

limpkin commented 5 months ago

@kbembedded some update on this one? :)

kbembedded commented 5 months ago

Its still a problem with some credentials, but, I was never able to find a correlation in testing.

The accounts I have that do it, if I copy their password to a test credential, the test credential does not reproduce it. So I'm not sure if its somehow related to the TOTP key used, something broken with my device's db, etv.

limpkin commented 5 months ago

Could you recreate the credential altogether to try to see if it might have been caused by a previous firmware version perhaps?

On Sun, Jan 7, 2024, 07:37 Kris Bahnsen @.***> wrote:

Its still a problem with some credentials, but, I was never able to find a correlation in testing.

The accounts I have that do it, if I copy their password to a test credential, the test credential does not reproduce it. So I'm not sure if its somehow related to the TOTP key used, something broken with my device's db, etv.

— Reply to this email directly, view it on GitHub https://github.com/mooltipass/minible/issues/393#issuecomment-1879971311, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPCNM6IAWDNDBMJCEJXDKLYNI7ENAVCNFSM6AAAAAAWCYT4LSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZHE3TCMZRGE . You are receiving this because you commented.Message ID: @.***>

kbembedded commented 5 months ago

I can but I'm not going to right now because I'd have to regen TOTP and re-store all of the backup keys, etc. But also, if somehow its related to TOTP, generating a new key may just happen to make it go away.

I'll try and re-create a credential in the next couple of days.

kbembedded commented 5 months ago

I tried a few times, but was unable to cause it to occur with any new credentials that I created. Probably fine to just close this out.