search

mooltipass / moolticute

Mooltipass crossplatform daemon/tools
GNU General Public License v3.0
143 stars 67 forks source link

add disable TLD check option #1125

Closed rsrdesarrollo closed 1 year ago

rsrdesarrollo commented 1 year ago

fix #1100

It adds a new config option checkbox and skips TLD validation when setting is enabled.

bertvandepoel commented 1 year ago

I'm not very good at compiling Qt apps on my (relatively old) OS 😓 Would you mind including a screenshot? I'm hoping to help with the UX. While moolticute is very useable for IT people, it's proving to be really difficult for more regular users. I'm hoping to help improve that :)

rsrdesarrollo commented 1 year ago

@deXol done!

bertvandepoel commented 1 year ago

Does this PR exclusively add a setting, or does it also include some kind of warning or other indication when TLDs are listed that are not in the built-in list? I must admit I'm really not a fan of current behaviour where they are silently ignored (though I'm not sure that discussion is "in scope" for this PR)

limpkin commented 1 year ago

@bertvandepoel have a look at https://github.com/mooltipass/moolticute/pull/1128 that we just merged... I think it does what you want :)

bertvandepoel commented 1 year ago

Awesome! :D Nevermind about what I said then!

deXol commented 1 year ago

@rsrdesarrollo Window size constants are good now, but the Settings page is still off: kép Moolticute Settings text should be on the top and View daemon log should be a line above.

rsrdesarrollo commented 1 year ago

@deXol now is really done.

rsrdesarrollo commented 1 year ago

and now is really really done xD

P.D: I hate qt-creator

limpkin commented 1 year ago

thanks a lot @rsrdesarrollo !