Improve qmake install - Githubissues

mooltipass / moolticute

Mooltipass crossplatform daemon/tools

GNU General Public License v3.0

143 stars 67 forks source link

Improve qmake install #1134

Closed principis closed 7 months ago

principis commented 1 year ago

This PR add's missing files to the qmake install set and replaces cp with INSTALL_FILE to preserve access/modification times and set the mode correctly.

This is a draft PR, because I haven't had time yet to check everything, and to encourage others to add corrections.

bobsaintcool commented 1 year ago

Not an expert on qmake syntax but love the use of install in place of cp

principis commented 10 months ago

Updated the PR and fixed the metainfo path. Should be fine now.

limpkin commented 10 months ago

tagging @raoulh @deXol for review

limpkin commented 10 months ago

yet another stupid question: is that change compatible with old Linux OSes? I think we have launchpad still compiling for 16.04...

principis commented 10 months ago

Should be, but I'll check and report back.

principis commented 7 months ago

Sorry for the delay. Just tested it on Ubuntu 16.04 VM, and works fine.