Closed principis closed 7 months ago
Not an expert on qmake syntax but love the use of install in place of cp
Updated the PR and fixed the metainfo path. Should be fine now.
tagging @raoulh @deXol for review
yet another stupid question: is that change compatible with old Linux OSes? I think we have launchpad still compiling for 16.04...
Should be, but I'll check and report back.
Sorry for the delay. Just tested it on Ubuntu 16.04 VM, and works fine.
This PR add's missing files to the qmake install set and replaces
cp
withINSTALL_FILE
to preserve access/modification times and set the mode correctly.This is a draft PR, because I haven't had time yet to check everything, and to encourage others to add corrections.