mooltipass / moolticute

Mooltipass crossplatform daemon/tools
GNU General Public License v3.0
143 stars 67 forks source link

Password generator slider has maximum length of 31 #1174

Closed hijackeel closed 1 year ago

hijackeel commented 1 year ago

Expected behavior

Password length slider in random generator should go up to maximum of 64.

Actual behavior

Password length slider in generator goes up to maximum of 31.

Step by step guide to reproduce the problem

  1. Open Moolticute.
  2. Go to Credentials tab.
  3. Click on Random Password icon in Password field.
  4. Try to make length slider greater than 31.

Moolticute Version

Latest commit at time of writing: c4939e599487749ad47d8d5afb1dc2862d73bc89

Operating System

Gentoo Linux

warrenc5 commented 1 year ago

Funnily I was just encountering the same edge case when adding an IKE pre shared key for IPSEC/L2TP

Seems the protocol maximum is 127 however some Cisco supports 64 and some routers only support 32 characters.

I kind of agree 127 would be a sensible limit to be supported on the Mool - after that point you would want probably want to use a different security mechanism like DH keys no?