mooltipass / moolticute

Mooltipass crossplatform daemon/tools
GNU General Public License v3.0
141 stars 66 forks source link

multiple password changes not reflected in the credential list #1217

Closed alanrick closed 3 months ago

alanrick commented 3 months ago

Expected behavior

When I make a password change to two logins I should be able to navigate between them and verify them before updating the BLE database.

Actual behavior

After changing the password for the 1st login, and then the password for the 2nd login, when I navigate back to the first login, I should see the changed first password not the original password.

Step by step guide to reproduce the problem

E.g. Service "Router". Login 1 "user", password "1pass" Login 2 "admin", password "2pass"

  1. Navigate to credentials, service Router ,
  2. Navigate to login, user
  3. Change the password to 1pass1 and press -Confirm changes-
  4. Navigate to login, admin
  5. Change the password to 2pass2 and press -Confirm changes-
  6. Now, Navigate back to the user login and view the password. It is not 1pass1 as expected but 1pass (the old password)

And the date modified date is not changed either. If I now select and reload in fact the password has been changed (to 1pass1). But this is misleading because when I checked it before pressing Save all changes this value is not the value that is saved in the database.

It also inconsistent with adding a service while in the credentials mode because this service DOES appear in the list of credentials even though it will be lost if I don't press E.g.

  1. Add the Service Router, Login User2, password 3pass.
  2. This is appears in the list of services correctly (even though it has not been saved to the BLE)

It is also inconsistent with deleting a credential which likewise is immediately reflected in the list even though it has not been saved back to the BLE.

Moolticute Version

v1.03.0

Operating System

Mention if you are using either:

Other operating systems are not supported.

Mooltipass Device

Mention if you are using either:

(updated as I'd inadvertently added formatting)

limpkin commented 3 months ago

ohhhh that's a very nice find! thanks @alanrick