mooltipass / moolticute

Mooltipass crossplatform daemon/tools
GNU General Public License v3.0
141 stars 66 forks source link

Adding extra spaces to passwords when ' or " are used in the password #1221

Open Drakx opened 2 months ago

Drakx commented 2 months ago

Expected behaviour

No extra spaces to be added

Take the following example, used as a password produced via the extension bL/jG1-$5xgov)wz/]X'g}C|dnqu(ey

Please note that this has been changed already and is no longer in use.

Actual behaviour

Password will be added with an extra space

bL/jG1-$5xgov)wz/]X 'g}C|dnqu(ey

Notice the extra space between "X 'g" This happens when using any website where this is filled in for the password field. Because this was an actual password that has since been changed that got reported as incorrect I used Notepad to type out the credentials everything was correct until that extra space. Viewing the password in the credentials in the app looks to be correct

Step-by-step guide to reproduce the problem

Windows 10 Firefox Developer Edition Mooltipass Extension installed Moolticute installed Under device settings for Moolticute set Bluetooth and USB keyboard Layout to US International

Moolticute Version

1.03.0 Bundle version 13

Operating System

Mention if you are using either:

Mooltipass Extension

Mooltipass Device

Drakx commented 2 months ago

Digging a liitle more in to this issue, I have noticed that this bug appears in any password that contains the following characters " or ' Extra spaces are inputted when none should exist. The screenshot shows that there appers to be no spaces, but when used in notpad the following is produced You' havea" space!here https://ibb.co/M1cNFHZ

I'm yet to confirm that this is the same for macOS.

limpkin commented 2 months ago

this looks like a dead key issue where the device types an extra space for special characters.... but can't be sure because the step by step guide is incomplete. are you using a special keyboard layout

Drakx commented 2 months ago

Yes, I use Dvorak as my layout, configured by the keyboard, Windows set to ENG US International. What steps would you need to replicate the issue?

limpkin commented 2 months ago

I think you should set the keyboard layout to dvorak in moolticute settings then :)

Drakx commented 2 months ago

I have and that produces the following

kd;k f;dolamd kjg;ra;;,soh,gppqja.dQa";raid

As you can see from the screenshot, this is wrong https://ibb.co/b6TGQWt

When set back to US international for USB keyboard layout test username thispasswordwill' have@ a"space

the username matches but thats it.

limpkin commented 2 months ago

I think I may need to add a setting to disable the dead keys feature on the Mini BLE.... Did you install any kind of software on your computer regarding your dvorak keyboard? standard windows behavior with US layout is when typing " then the character won't be typed right away

Drakx commented 2 months ago

I use https://www.zsa.io/moonlander/ and configured it with https://configure.zsa.io/moonlander/layouts/ no other software is used to configure the keyboard. Luckily this keyboard allows me to configure it using their configurator which allows me to set the OS to my preferred language choice without having to set the OS to Dvorak.

Drakx commented 2 months ago

I think I've found a workaround. Setting the keyboard to UK (MacOS) seems to be working as expected.

limpkin commented 2 months ago

that's... odd.

limpkin commented 2 months ago

should I close the issue? From the mini ble side of things, there shouldn't be a difference regarding dead keys between us & uk layouts :/

Drakx commented 2 months ago

I don't know. All I know is that it appears to be working while set to UK layout, maybe something to keep an eye on if someone else reports the issue.

On Sun, Apr 21, 2024, 17:45 Mathieu @.***> wrote:

should I close the issue? From the mini ble side of things, there shouldn't be a difference regarding dead keys between us & uk layouts :/

— Reply to this email directly, view it on GitHub https://github.com/mooltipass/moolticute/issues/1221#issuecomment-2068131012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJNYLPZ2AOAUPBXJ3CJ4ULY6PUMDAVCNFSM6AAAAABGNC6GQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGEZTCMBRGI . You are receiving this because you authored the thread.Message ID: @.***>

limpkin commented 2 months ago

makes sense