moolticute's build system is trying to install qzxing.h

[barathrm]

It seems like the opensuse tumbleweed build has been failing for a little while with

[  101s] error: Installed (but unpackaged) file(s) found:
[  101s]    /usr/include/QZXing.h
[  101s]    /usr/include/QZXing_global.h

I assume it's related to the recent QZXing library submodule changes.

I'll look into it when I have time, making an issue to track it until then.

I assume that installing the header is unintentional since it was not being installed before?

ref

• https://github.com/mooltipass/moolticute/commit/bda1c4264a2e45f1a0f558f963a2c0dd6ae07efb
• https://github.com/mooltipass/moolticute/commit/3befd02c50258da268b096bc88c9377e62d48bb2
• https://github.com/mooltipass/moolticute/commit/4f9a9e99ef4a744caf32adf60ba77340e47d8e04

[barathrm]

fyi @deXol

[limpkin]

@barathrm I'm guessing this is because the submodules are not fetched when building? :)

[barathrm]

@barathrm I'm guessing this is because the submodules are not fetched when building? :)

hm I dont understand :thinking: the above error means that make (?) installed the files in the staging environment (to /usr/include/QZXing.h), but since the rpm .spec file didn't list them to be included in the package, they're ignored.

In other words I'd expect that if you run make install you'll get the headers installed on your system.

And I just double-checked building the OBS project locally; the submodule is correctly cloned.

[barathrm]

Here are the logs from OBS showing the file being installed (but not packaged by me, hence the error)

[ 102s] /usr/bin/qmake-qt5 -install qinstall /home/abuild/rpmbuild/SOURCES/moolticute-testing-1.03.17.r0.gba0f3a0/src/QZXing/src/QZXing.h /home/abuild/rpmbuild/BUILDROOT/moolticute-testing-1.03.17.r0.gba0f3a0-58.1.x86_64/usr/include/QZXing.h [ 102s] /usr/bin/qmake-qt5 -install qinstall /home/abuild/rpmbuild/SOURCES/moolticute-testing-1.03.17.r0.gba0f3a0/src/QZXing/src/QZXing_global.h /home/abuild/rpmbuild/BUILDROOT/moolticute-testing-1.03.17.r0.gba0f3a0-58.1.x86_64/usr/include/QZXing_global.h

[barathrm]

Okay just double-checked the OBS logged and the first build failed when moolticute-testing was bumped from v1.03.15-testing to v1.03.16-testing. So I assume it's somehow related to the submodule transition, but from reading the QZXing-components.pri file, I don't see how... the old one seems to refer to the same header files :thinking:

• old https://github.com/mooltipass/moolticute/blob/5982884943cda70743b9c79375d69d1b43bf2adc/src/QZXing/QZXing-components.pri#L461
• new https://github.com/mooltipass/qzxing/blob/7e9ce8b2819c64d0641618588acd844d29cdf76f/src/QZXing-components.pri#L461

I'll try building the older commit before transitioning to using the submodule when I have the chance to see whether it does not install those headers.