mooltipass / moolticute

Mooltipass crossplatform daemon/tools
GNU General Public License v3.0
143 stars 67 forks source link

utils: Use QUrl/QUrlQuery to parse urls #1237

Closed nekromant closed 1 month ago

nekromant commented 1 month ago

Apart from not 'reinventing the wheel', this fixes urldecoding in QR code logins that use urlencoded characters e.g. cloudflare.

When cloudflare's QR code was detected by mooltipass app, it decoded the login (which, in turn, was an email address) with %40 instead of @ and created another credential with no password. That in turn caused the app to misbehave, not update password (Perhaps related to #1233 ) and it took several attempts to delete the incorrect login and update.