mooltiverse / nyx

The one stop semantic release tool
https://github.com/mooltiverse/nyx
Apache License 2.0
116 stars 8 forks source link

Commits appear only once in changelog even when they should match the convention multiple times (Go) #262

Closed flelli closed 1 year ago

flelli commented 1 year ago

It looks like the FindNextMatch from regexp2 (we need it in place of regexp because we need so called lookarounds) fails to return next matches. Sometimes, even with the same test data, it does return next matches but the GroupByName method of the returned object then fails to return the capturing group value.

This bug affects the make task when it builds the changelog using commits with multiple types assigned. It is an edge case that maybe doesn't even affect anyone and, if it does, it means the same commit only appears once in the changelog instead of multiple times in multiple sections, but yet it's worth solving.

For more on commit message conventions matching multiple tokens, like for merge commits, are covered in #125 .

This issue is limited to the Go version, while Java works fine.

flelli commented 1 year ago

False positive, this was not a defect in regexp2. The issue was due to a bug in Nyx, solved before releasing the feature.