search

moonbeam-foundation / crowdloan-rewards

Substrate pallet that enables parachains to issue rewards to crowdloan contributors in parachain-native tokens.
12 stars 16 forks source link

Update dependencies (No longer depend on Polkadot-service) #23

Closed JoshOrndorff closed 3 years ago

JoshOrndorff commented 3 years ago

This PR points the dependencies to newer branches. This allows us to no longer depend on polkadot-service (which itself depends on all four polkadot runtimes). This speeds the building and testing of this pallet considerably.

Before this PR

$ cargo tree -i polkadot-service

polkadot-service v0.9.4 (https://github.com/paritytech/polkadot?branch=release-v0.9.4#2f28561a)
└── cumulus-primitives-parachain-inherent v0.1.0 (https://github.com/purestake/cumulus?branch=nimbus-polkadot-v0.9.4#51adcf4d)
    ├── cumulus-pallet-parachain-system v0.1.0 (https://github.com/purestake/cumulus?branch=nimbus-polkadot-v0.9.4#51adcf4d)
    │   └── pallet-crowdloan-rewards v0.6.0 (/home/joshy/ProgrammingProjects/crowdloan-rewards)
    └── pallet-crowdloan-rewards v0.6.0 (/home/joshy/ProgrammingProjects/crowdloan-rewards)

With this PR

$ cargo tree -i polakdot-service

error: package ID specification `polakdot-service` did not match any packages
girazoki commented 3 years ago

Does not seem to be able to compile cumulus-pallet-parachain-system. Anything we are missing?

JoshOrndorff commented 3 years ago

CI is failing because it pulled the latest Substrate which cumulus is incompatible with. We have this problem because Cumulus doesn't depend on Substrate's published versions.

We could introduce a Cargo.lock as a way to communicate what versions we've tested with. It isn't in line with https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries but doesn't seem totally unreasonable.

JoshOrndorff commented 3 years ago

Closing in favor of #24