search

moonbeam-foundation / crowdloan-rewards

Substrate pallet that enables parachains to issue rewards to crowdloan contributors in parachain-native tokens.
12 stars 16 forks source link

Fixes an incorrect doc comment #45

Closed JoshOrndorff closed 3 years ago

JoshOrndorff commented 3 years ago

The description of EndRelayBlock was incorrectly copied from InitRelayBlock. This pr fixes that.

JoshOrndorff commented 3 years ago

The code changes are from cargo fmt. I ran it when I saw that CI was failing. But now it is still failing. Of course this would turn into a complicated debugging task.

girazoki commented 3 years ago

Taking a look at why this is failing, something must have changed in some dependency.

girazoki commented 3 years ago

The summary is that for some reason importing cumulus-pallet-parachain-system or cumulus-primitives-parachain-inherent fails now, not sure exactly why, but it has to do with this snow dependency that ends up being imported because of those two packages. A Cargo.lock file solves the issue temporarily, the other solution is to continue the work on removing cumulus dependencies

JoshOrndorff commented 3 years ago

Looks good to me. Thanks for making it build @girazoki