search

moonbeam-foundation / crowdloan-rewards

Substrate pallet that enables parachains to issue rewards to crowdloan contributors in parachain-native tokens.
12 stars 16 forks source link

Errors trying to integrate into another parachain #52

Open ltfschoen opened 2 years ago

ltfschoen commented 2 years ago

I get the errors shown in the description of this PR when trying to incorporate this pallet into another parachain https://github.com/DataHighway-DHX/DataHighway-Parachain/pull/18

crystalin commented 2 years ago

It seems to be missing some particular trait but I'm not sure which one. @girazoki can have a look at it this week

girazoki commented 2 years ago

Hi @ltfschoen, how can I replicate your error? What kind of build are u making to get these errors?

ltfschoen commented 2 years ago

@girazoki i'm just running the following. the repository is based on the substrate-parachain-template

git clone https://github.com/DataHighway-DHX/DataHighway-Parachain
git fetch origin luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards:luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards
git checkout luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards
./scripts/init.sh
cargo build --release
girazoki commented 2 years ago

Hi @ltfschoen, the main reason for the failure I think is that we have our own forks of substrate/cumulus and it conflicts with yours. I created a branch in this repo called polkadot-v0.9.17, that you can use for your project, that points at the parity versions of substrate/cumulus.

I tried compiling your runtime with this new branch and it works. Feel free to use it, and also remind us to create appropriate branches as we continue upgrading this pallet