moonbeam-foundation / moonbeam

An Ethereum-compatible smart contract parachain on Polkadot
https://moonbeam.network
GNU General Public License v3.0
916 stars 321 forks source link

chore(CI): Increase coverage timeout to 90 minutes #2847

Closed RomarQ closed 5 days ago

RomarQ commented 6 days ago

What does it do?

This change increases the timeout of the coverage job from 60 to 90 minutes.

Also updates some CI dependencies:

https://github.com/moonbeam-foundation/moonbeam/pull/2836 - Bump docker/build-push-action from 4 to 5 https://github.com/moonbeam-foundation/moonbeam/pull/2835 - Bump peaceiris/actions-gh-pages from 3 to 4 https://github.com/moonbeam-foundation/moonbeam/pull/2834 - Bump pnpm/action-setup from 3 to 4 https://github.com/moonbeam-foundation/moonbeam/pull/2833 - Bump docker/setup-buildx-action from 3.2.0 to 3.3.0

What important points reviewers should know?

Some dependency is causing the instrumented binary to be a bit slow (both to build and to execute) and for that reason we have to increase the coverage timeout temporarily until it gets fixed by new versions of the respective dependency. I do not know what dependency is causing this, but @librelois suggested that we can use RUSTFLAGS="-Z time-passes" to possible identify the culpit.

github-actions[bot] commented 6 days ago

Coverage Report

@@                   Coverage Diff                   @@
##           master   ci-coverage-timeout      +/-   ##
=======================================================
+ Coverage   81.23%                81.34%   +0.11%     
  Files         301                   301              
+ Lines       85514                 85698     +184     
=======================================================
+ Hits        69462                 69704     +242     
- Misses      16052                 15994      -58     
Files Changed Coverage
/node/cli/src/command.rs 19.23% (+0.07%) 🔼
/node/service/src/lib.rs 61.64% (+0.26%) 🔼
/node/service/src/rpc.rs 84.90% (-2.29%) 🔽
/pallets/erc20-xcm-bridge/src/mock.rs 13.33% (+13.33%) 🔼
/pallets/moonbeam-orbiters/src/lib.rs 74.71% (+1.95%) 🔼
/pallets/parachain-staking/src/lib.rs 91.73% (+0.86%) 🔼
/primitives/xcm/src/asset_id_conversions.rs 47.62% (+0.25%) 🔼
/runtime/common/src/apis.rs 30.52% (-1.07%) 🔽
/runtime/common/src/migrations.rs 97.95% (+97.95%) 🔼
/runtime/common/src/weights/pallet_scheduler.rs 12.12% (-5.58%) 🔽
/runtime/moonbase/src/lib.rs 53.45% (-0.27%) 🔽
/runtime/moonbase/src/migrations.rs 100.00% (+100.00%) 🔼
/runtime/moonbase/src/xcm_config.rs 54.35% (-1.21%) 🔽
/runtime/moonbase/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽
/runtime/moonbeam/src/lib.rs 47.29% (-0.23%) 🔽
/runtime/moonbeam/src/migrations.rs 66.67% (+66.67%) 🔼
/runtime/moonbeam/src/xcm_config.rs 54.35% (-1.21%) 🔽
/runtime/moonbeam/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽
/runtime/moonriver/src/lib.rs 47.37% (-0.23%) 🔽
/runtime/moonriver/src/migrations.rs 66.67% (+66.67%) 🔼
/runtime/moonriver/src/xcm_config.rs 52.17% (-1.16%) 🔽
/runtime/moonriver/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽

Coverage generated Tue Jun 25 14:41:20 UTC 2024