Closed RomarQ closed 1 month ago
Moonbase runtime: 2260 KB (no changes) ✅
Moonbeam runtime: 2228 KB (no changes) ✅
Moonriver runtime: 2232 KB (no changes) ✅
Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️
Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️
Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️
@@ Coverage Diff @@
## master rq/fix-moonbase-metadata-hash +/- ##
================================================================
Coverage 79.01% 79.01% 0.00%
Files 305 305
Lines 88446 88446
================================================================
Hits 69878 69878
Misses 18568 18568
Files Changed | Coverage |
---|
Coverage generated Wed Oct 16 15:26:09 UTC 2024
What does it do?
Uses the original moonbase token symbol when using
metadata-hash
transaction extension.The original token symbol used in moonbase is
DEV
and notUNIT
. When leveraging metadata hash, the token symbol is included in the metadata digest and would cause the transaction to fail.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?