moonbeam-foundation / moonbeam

An Ethereum-compatible smart contract parachain on Polkadot
https://moonbeam.network
GNU General Public License v3.0
921 stars 337 forks source link

Support integer `u64` in `eth_feeHistory` #3018

Closed gonzamontiel closed 3 weeks ago

gonzamontiel commented 1 month ago

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

github-actions[bot] commented 1 month ago

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

github-actions[bot] commented 1 month ago

Coverage Report

@@                          Coverage Diff                          @@
##           master   gonza/support-uint-eth-fee-history     +/-   ##
=====================================================================
  Coverage   79.01%                               79.01%   0.00%     
  Files         305                                  305             
  Lines       88447                                88447             
=====================================================================
  Hits        69878                                69878             
  Misses      18569                                18569             
Files Changed Coverage

Coverage generated Wed Oct 30 20:49:14 UTC 2024