Foreign Assets Migration

[ahmadkaouk]

What does it do?

This PR is a follow up of #2869 , it manage the migration of existing foreign assets to the new design. The PR introduces four extrinsics in pallet-moonbeam-lazy-migration to handle the migration of a foreign asset.

start_foreign_asset_migration

• Initiates migration for a specific foreign asset
• Freezes the original asset to prevent further transactions
• Creates new EVM smart contract via the new moonbeam-foreign-assets pallet
• Stores migration state including remaining balances and approvals count

migrate_foreign_asset_balances

• Migrates asset balances in batches (controlled by limit parameter)
• Drains balances from old assets pallet
• Mints equivalent amounts in new foreign assets system
• Updates remaining balances counter

migrate_foreign_asset_approvals

• Migrates asset approvals in batches (controlled by limit parameter)
• Drains approvals from old assets pallet
• Creates equivalent approvals in new foreign assets system
• Unreserves deposits from old approval system
• Updates remaining approvals counter

finish_foreign_asset_migration

• Completes migration after all balances and approvals are migrated
• Performs final cleanup of old asset storage
• Unreserves deposits from asset creation and metadata

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions[bot]]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2256 KB (no changes) ✅

Moonbeam runtime: 2236 KB (no changes) ✅

Moonriver runtime: 2236 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2256 KB (+228 KB compared to latest release) ⚠️

Moonbeam runtime: 2236 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2236 KB (+244 KB compared to latest release) ⚠️

[github-actions[bot]]

Coverage Report

@@                        Coverage Diff                         @@
##           master   ahmad-foreign-assets-migration      +/-   ##
==================================================================
- Coverage   74.70%                           74.57%   -0.13%     
+ Files         369                              375       +6     
+ Lines       94308                            95532    +1224     
==================================================================
+ Hits        70445                            71239     +794     
+ Misses      23863                            24293     +430     

Files Changed	Coverage
/pallets/moonbeam-foreign-assets/src/evm.rs	74.02% (+3.24%)	🔼
/pallets/moonbeam-foreign-assets/src/lib.rs	72.61% (+2.21%)	🔼
/pallets/moonbeam-lazy-migrations/src/lib.rs	80.17% (-1.87%)	🔽
/pallets/moonbeam-lazy-migrations/src/mock.rs	67.86% (-7.90%)	🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs	97.96% (-1.31%)	🔽

Coverage generated Fri Nov 29 13:57:30 UTC 2024