moonbeam-foundation / moonbeam

An Ethereum-compatible smart contract parachain on Polkadot
https://moonbeam.network
GNU General Public License v3.0
921 stars 337 forks source link

Remove suicided contracts lazy migration #3039

Closed RomarQ closed 1 week ago

RomarQ commented 2 weeks ago

What does it do?

Removes all logic related to the suicided contracts storage removal in pallet moonbeam-lazy-migrations.

The migration was already applied to the following runtimes:

github-actions[bot] commented 2 weeks ago

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (-4 KB) ✅

Moonbeam runtime: 2232 KB (+4 KB) ⚠️

Moonriver runtime: 2224 KB (-8 KB) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2232 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+232 KB compared to latest release) ⚠️

github-actions[bot] commented 2 weeks ago

Coverage Report

@@                            Coverage Diff                            @@
##           master   rq/remove-suicided-contracts-migration     +/-   ##
=========================================================================
  Coverage   79.00%                                   79.00%   0.00%     
- Files         305                                      303      -2     
- Lines       88470                                    88208    -262     
=========================================================================
- Hits        69890                                    69685    -205     
- Misses      18580                                    18523     -57     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 82.04% (-1.50%) 🔽
/pallets/moonbeam-lazy-migrations/src/mock.rs 75.76% (+8.19%) 🔼
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.27% (-0.28%) 🔽

Coverage generated Mon Nov 18 10:04:59 UTC 2024