fix: FeesTreasuryProportion is only applied to substrate based tx only

[TarekkMA]

What does it do?

Apply FeesTreasuryProportion to Substate-based txs tips, and Ethereum-based transactions fees.

• Changes have been applied to all runtimes.
• Tests for all Eth txs, and substrate txs (with and without tip) have been introduced for different FeesTreasuryProportion values.
• Parameters test refactorings

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

• 2923 Where this got added to moonbase.

• 2941 Where it got added to moonriver and moonbeam

[github-actions[bot]]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2264 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2264 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

[RomarQ]

Hi @TarekkMA, Please add a description to the issue.

[TarekkMA]

We still needs tests for it

[github-actions[bot]]

Coverage Report

@@                          Coverage Diff                           @@
##           master   tarekkma/fix-fee-treasury-propotion     +/-   ##
======================================================================
  Coverage   79.00%                                79.00%   0.00%     
  Files         305                                   305             
+ Lines       88458                                 88470     +12     
======================================================================
+ Hits        69878                                 69890     +12     
  Misses      18580                                 18580             

Files Changed	Coverage
/runtime/moonbase/src/lib.rs	52.85% (+0.30%)	🔼
/runtime/moonbeam/src/lib.rs	47.11% (+0.33%)	🔼
/runtime/moonriver/src/lib.rs	47.34% (+0.34%)	🔼

Coverage generated Thu Nov 14 20:04:13 UTC 2024