moonbeam-foundation / moonbeam

An Ethereum-compatible smart contract parachain on Polkadot
https://moonbeam.network
GNU General Public License v3.0
921 stars 337 forks source link

Lazy loading improvements #3048

Closed RomarQ closed 6 days ago

RomarQ commented 1 week ago

What does it do?

Removes redundant code by reusing the LocalCallExecuter from polkadot-sdk

github-actions[bot] commented 1 week ago

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2264 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2264 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

github-actions[bot] commented 1 week ago

Coverage Report

@@                       Coverage Diff                       @@
##           master   rq/lazyloading-improvements      +/-   ##
===============================================================
+ Coverage   79.00%                        79.33%   +0.33%     
  Files         303                           303              
- Lines       88208                         88096     -112     
===============================================================
+ Hits        69685                         69890     +205     
- Misses      18523                         18206     -317     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 83.54% (+1.50%) 🔼
/pallets/moonbeam-lazy-migrations/src/mock.rs 67.57% (-8.19%) 🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.55% (+0.28%) 🔼

Coverage generated Tue Nov 19 00:09:04 UTC 2024

TarekkMA commented 6 days ago

Looks good now code is more simple using polkadot-sdk Executer