moonbeam-foundation / moonbeam

An Ethereum-compatible smart contract parachain on Polkadot
https://moonbeam.network
GNU General Public License v3.0
920 stars 337 forks source link

feat: don't override fork strategy in import_queue #3049

Closed RomarQ closed 6 days ago

RomarQ commented 1 week ago

What does it do?

Supersedes https://github.com/moonbeam-foundation/moonbeam/pull/2794

Historically aura was overcharging fork strategy for parachain at block import, but seems no longer necessary.

This PR updates nimbus to remove the NimbusBlockImport type, a wrapper that impl BlockImport only to override the fork strategy.

What important points reviewers should know?

github-actions[bot] commented 1 week ago

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2232 KB (no changes) ✅

Moonriver runtime: 2224 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2232 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+232 KB compared to latest release) ⚠️

github-actions[bot] commented 1 week ago

Coverage Report

@@                     Coverage Diff                      @@
##           master   rq/block-import-pipeline      +/-   ##
============================================================
+ Coverage   74.81%                     78.94%   +4.13%     
- Files         369                        303      -66     
- Lines       94137                      88282    -5855     
============================================================
- Hits        70421                      69688     -733     
- Misses      23716                      18594    -5122     
Files Changed Coverage
/node/cli/src/cli.rs 32.93% (-0.40%) 🔽
/node/cli/src/command.rs 16.90% (-0.71%) 🔽
/node/service/src/lib.rs 61.42% (-0.83%) 🔽
/precompiles/relay-data-verifier/src/mock.rs 87.69% (+2.16%) 🔼
/runtime/moonbeam/src/xcm_config.rs 45.45% (+2.18%) 🔼
/runtime/moonbeam/tests/common/mod.rs 94.68% (-0.06%) 🔽
/runtime/moonriver/src/xcm_config.rs 45.45% (+2.18%) 🔼
/runtime/moonriver/tests/common/mod.rs 94.80% (-0.05%) 🔽

Coverage generated Fri Nov 22 13:25:53 UTC 2024