moonbeam-foundation / xcm-sdk

The Moonbeam XCM SDK enables developers to easily transfer assets between chains, either between parachains or between a parachain and the relay chain, within the Polkadot/Kusama ecosystem. With the SDK, you don't need to worry about determining the multilocation of the origin or destination assets or which extrinsics are used on which networks to
https://moonbeam-foundation.github.io/xcm-sdk/latest/
MIT License
14 stars 9 forks source link

Migrated from npm to pnpm #315

Closed ekenigs closed 2 months ago

ekenigs commented 2 months ago

Description

Please explain the changes this PR addresses here.

Checklist

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 8cebc5bafaf1aea16e0fdd86f0cf542e65532704

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@polkadot/api-augment@12.2.1, npm/@polkadot/api@12.2.1, npm/@polkadot/types@12.2.1, npm/@typescript-eslint/eslint-plugin@7.16.1, npm/@typescript-eslint/parser@7.16.1

View full report↗︎

ekenigs commented 2 months ago

I have a problem when trying to link

@moonbeam-network/mrl:link: @moonbeam-network/mrl:link: > @moonbeam-network/mrl@0.0.1 link /home/mmaurello/gitData/xcm-sdk/packages/mrl @moonbeam-network/mrl:link: > pnpm ln @moonbeam-network/mrl:link: @moonbeam-network/xcm-config:link:  ERR_PNPM_LINK_BAD_PARAMS  You must provide a parameter @moonbeam-network/xcm-builder:link:  ERR_PNPM_LINK_BAD_PARAMS  You must provide a parameter @moonbeam-network/xcm-config:link:  ELIFECYCLE  Command failed with exit code 1. @moonbeam-network/xcm-config:link: ERROR: command finished with error: command (/home/mmaurello/gitData/xcm-sdk/packages/config) /home/mmaurello/.nvm/versions/node/v20.12.2/bin/pnpm run link exited (1) @moonbeam-network/xcm-builder:link:  ELIFECYCLE  Command failed with exit code 1. @moonbeam-network/xcm-config#link: command (/home/mmaurello/gitData/xcm-sdk/packages/config) /home/mmaurello/.nvm/versions/node/v20.12.2/bin/pnpm run link exited (1)

You are right, it works a bit differently then in NPM https://pnpm.io/cli/link#use-cases. It might be that to use it in our other projects we need to migrate to pnpm them too. But I will check this later. I will find a solution later. For now is important that we can build.