use toFixed to prevent transformins scientific notation to bigint error

moonbeam-foundation / xcm-sdk

The Moonbeam XCM SDK enables developers to easily transfer assets between chains, either between parachains or between a parachain and the relay chain, within the Polkadot/Kusama ecosystem. With the SDK, you don't need to worry about determining the multilocation of the origin or destination assets or which extrinsics are used on which networks to

https://moonbeam-foundation.github.io/xcm-sdk/latest/

MIT License

14 stars 9 forks source link

use toFixed to prevent transformins scientific notation to bigint error #90

Closed mmaurello closed 1 year ago

mmaurello commented 1 year ago

Description

By using toString, numbers with order of magnitude bigger than 21 are shown in scientific notation. By converting to bigint, we get an error

Using toFixed will ensure that this doesn't happen

Checklist

[x] If this requires a documentation change, I have created a PR in moonbeam-docs repository.
[x] If this requires it, I have updated the Readme
[x] If necessary, I have updated the examples
[x] I have verified if I need to create/update unit tests
[x] I have verified if I need to create/update acceptance tests
[x] If necessary, I have run acceptance tests on this branch in CI

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: aec85d6214da8af54894631285862075f87cdecc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR