Closed qazxcdswe123 closed 4 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
json/types.mbt | 7 | 8 | 87.5% | ||
<!-- | Total: | 15 | 16 | 93.75% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
double/ryu.mbt | 1 | 93.58% | ||
immut/sorted_map/map.mbt | 2 | 79.66% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 1656: | -0.1% |
Covered Lines: | 2623 |
Relevant Lines: | 2959 |
Thanks, these mistakes are stupid 😢
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
double/ryu.mbt | 1 | 93.58% | ||
immut/sorted_map/map.mbt | 2 | 79.66% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 1656: | -0.06% |
Covered Lines: | 2624 |
Relevant Lines: | 2959 |
cc @peter-jerry-ye this may be a breaking change to downstream
close #524
Added custom
to_string
method forJSONValue
to match the test, andJSONValue
no longer deriveShow
TODO: #532