search

moonbitlang / core

MoonBit's Core library
https://moonbitlang.com/
Apache License 2.0
471 stars 54 forks source link

change bool to IterResult #538

Closed bobzhang closed 1 week ago

bobzhang commented 3 weeks ago
coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 1669

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/array.mbt 2 3 66.67%
<!-- Total: 2 3 66.67% -->
Totals Coverage Status
Change from base Build 1668: -0.02%
Covered Lines: 2626
Relevant Lines: 2962
💛 - Coveralls
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 1670

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/array.mbt 2 3 66.67%
<!-- Total: 2 3 66.67% -->
Totals Coverage Status
Change from base Build 1668: -0.02%
Covered Lines: 2626
Relevant Lines: 2962
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1893

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/array.mbt 5 6 83.33%
array/fixedarray.mbt 2 3 66.67%
immut/hashmap/bucket.mbt 2 3 66.67%
immut/hashset/bucket.mbt 2 3 66.67%
immut/list/list.mbt 1 2 50.0%
queue/queue.mbt 1 2 50.0%
string/string.mbt 2 3 66.67%
builtin/iter.mbt 44 49 89.8%
<!-- Total: 83 95 87.37% -->
Files with Coverage Reduction New Missed Lines %
builtin/linked_hash_map.mbt 1 98.9%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 1891: 0.08%
Covered Lines: 2938
Relevant Lines: 3530
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1894

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/array.mbt 5 6 83.33%
array/fixedarray.mbt 2 3 66.67%
immut/hashmap/bucket.mbt 2 3 66.67%
immut/hashset/bucket.mbt 2 3 66.67%
immut/list/list.mbt 1 2 50.0%
queue/queue.mbt 1 2 50.0%
string/string.mbt 2 3 66.67%
builtin/iter.mbt 44 49 89.8%
<!-- Total: 83 95 87.37% -->
Totals Coverage Status
Change from base Build 1891: 0.08%
Covered Lines: 2938
Relevant Lines: 3530
💛 - Coveralls
qazxcdswe123 commented 1 week ago

Accidentally ruined the commit history, but the diff should work just fine and the history should be cleaned after squash and merge.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1896

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
array/array.mbt 5 6 83.33%
array/fixedarray.mbt 2 3 66.67%
immut/hashmap/bucket.mbt 2 3 66.67%
immut/hashset/bucket.mbt 2 3 66.67%
immut/list/list.mbt 1 2 50.0%
queue/queue.mbt 1 2 50.0%
string/string.mbt 2 3 66.67%
builtin/iter.mbt 44 49 89.8%
<!-- Total: 83 95 87.37% -->
Totals Coverage Status
Change from base Build 1895: 0.08%
Covered Lines: 2938
Relevant Lines: 3531
💛 - Coveralls