moonbitlang / core

MoonBit's Core library
https://moonbitlang.com/
Apache License 2.0
464 stars 54 forks source link

improve coverages #586

Closed tonyfettes closed 6 days ago

tonyfettes commented 1 week ago
  1. changes all abort to panic for testing.
  2. add more test to improve coverages.
coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1852

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 18 85 21.18% -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1853

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 18 85 21.18% -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1854

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 18 85 21.18% -->
Files with Coverage Reduction New Missed Lines %
immut/priority_queue/priority_queue.mbt 1 92.5%
immut/array/tree.mbt 2 88.0%
immut/sorted_map/map.mbt 7 79.66%
immut/sorted_set/immutable_set.mbt 15 90.91%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1855

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 18 85 21.18% -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
tonyfettes commented 1 week ago

Most tests are written by AI and I had to manually modified the generated test cases at least 90% of the cases. Surprisingly it do improve the coverage a little bit.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1856

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes.mbt 1 2 50.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
<!-- Total: 19 82 23.17% -->
Files with Coverage Reduction New Missed Lines %
builtin/bytes.mbt 12 33.33%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1857

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 18 85 21.18% -->
Totals Coverage Status
Change from base Build 1849: 4.9%
Covered Lines: 3090
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1858

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 21 85 24.71% -->
Totals Coverage Status
Change from base Build 1849: 5.0%
Covered Lines: 3093
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1859

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/bytes_block.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
<!-- Total: 21 85 24.71% -->
Totals Coverage Status
Change from base Build 1849: 5.0%
Covered Lines: 3093
Relevant Lines: 3512

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1867

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
string/string.mbt 0 3 0.0%
<!-- Total: 22 84 26.19% -->
Totals Coverage Status
Change from base Build 1865: 5.8%
Covered Lines: 3126
Relevant Lines: 3517

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1868

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
string/string.mbt 0 3 0.0%
<!-- Total: 22 84 26.19% -->
Totals Coverage Status
Change from base Build 1865: 5.8%
Covered Lines: 3126
Relevant Lines: 3517

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1870

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
string/string.mbt 0 3 0.0%
<!-- Total: 22 84 26.19% -->
Totals Coverage Status
Change from base Build 1865: 5.8%
Covered Lines: 3126
Relevant Lines: 3517

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1878

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
string/string.mbt 0 3 0.0%
<!-- Total: 21 83 25.3% -->
Totals Coverage Status
Change from base Build 1876: 5.7%
Covered Lines: 3123
Relevant Lines: 3514

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 1888

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/array_block.mbt 0 1 0.0%
builtin/buffer.mbt 0 1 0.0%
builtin/console.mbt 0 1 0.0%
double/ryu.mbt 0 1 0.0%
immut/priority_queue/priority_queue.mbt 0 1 0.0%
priority_queue/priority_queue.mbt 0 1 0.0%
rational/rational.mbt 0 1 0.0%
devec/devec.mbt 0 2 0.0%
queue/queue.mbt 0 2 0.0%
string/string.mbt 0 3 0.0%
<!-- Total: 21 83 25.3% -->
Totals Coverage Status
Change from base Build 1876: 5.7%
Covered Lines: 3123
Relevant Lines: 3514

💛 - Coveralls
coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 1899

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/bytes.mbt 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 1895: 5.8%
Covered Lines: 3126
Relevant Lines: 3516

💛 - Coveralls
coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 1902

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/bytes.mbt 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 1895: 5.8%
Covered Lines: 3126
Relevant Lines: 3516

💛 - Coveralls