Closed Yoorkin closed 1 week ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
builtin/arraycore.mbt | 2 | 3 | 66.67% | ||
builtin/array.mbt | 0 | 2 | 0.0% | ||
<!-- | Total: | 6 | 9 | 66.67% | --> |
Totals | |
---|---|
Change from base Build 1865: | 0.0% |
Covered Lines: | 2922 |
Relevant Lines: | 3515 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
builtin/arraycore.mbt | 2 | 3 | 66.67% | ||
builtin/array.mbt | 0 | 2 | 0.0% | ||
<!-- | Total: | 6 | 9 | 66.67% | --> |
Totals | |
---|---|
Change from base Build 1876: | 0.0% |
Covered Lines: | 2920 |
Relevant Lines: | 3512 |
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
builtin/arraycore.mbt | 2 | 3 | 66.67% | ||
builtin/autoloc.mbt | 0 | 1 | 0.0% | ||
builtin/buffer.mbt | 2 | 3 | 66.67% | ||
builtin/console.mbt | 0 | 1 | 0.0% | ||
builtin/debug.mbt | 0 | 1 | 0.0% | ||
strconv/string_slice.mbt | 0 | 1 | 0.0% | ||
builtin/array.mbt | 0 | 2 | 0.0% | ||
<!-- | Total: | 15 | 23 | 65.22% | --> |
Totals | |
---|---|
Change from base Build 1876: | 0.004% |
Covered Lines: | 2921 |
Relevant Lines: | 3513 |
The old Buffer::make(Int)
will be removed later. Test driver generated by moon should use Buffer::new(~size_hint)
instead. @lijunchen
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
builtin/arraycore.mbt | 2 | 3 | 66.67% | ||
builtin/autoloc.mbt | 0 | 1 | 0.0% | ||
builtin/buffer.mbt | 2 | 3 | 66.67% | ||
builtin/console.mbt | 0 | 1 | 0.0% | ||
builtin/debug.mbt | 0 | 1 | 0.0% | ||
strconv/string_slice.mbt | 0 | 1 | 0.0% | ||
builtin/array.mbt | 0 | 2 | 0.0% | ||
<!-- | Total: | 15 | 23 | 65.22% | --> |
Totals | |
---|---|
Change from base Build 1886: | 0.004% |
Covered Lines: | 2921 |
Relevant Lines: | 3513 |
In this pr:
capacity
(maybe rename to size_hint in future) toT::new()
T::with_capacity
T::make()
toT::new()
This PR addresses part 1 of proposal #582.