search

moonbitlang / core

MoonBit's Core library
https://moonbitlang.com/
Apache License 2.0
464 stars 54 forks source link

feat: make Buffer::grow_if_necessary public #625

Closed KKKIIO closed 7 hours ago

KKKIIO commented 2 days ago

Making Buffer::grow_if_necessary public allows users to explicitly grow or pre-allocate memory, enabling various optimizations that can improve performance.

coderabbitai[bot] commented 2 days ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 2005

Details

Totals Coverage Status
Change from base Build 2004: 0.0%
Covered Lines: 3503
Relevant Lines: 3951
💛 - Coveralls
bobzhang commented 1 day ago

do you have a concrete use case for this API?

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 2019

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Files with Coverage Reduction New Missed Lines %
immut/hashmap/HAMT.mbt 1 71.43%
immut/hashset/HAMT.mbt 1 73.85%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2004: 0.9%
Covered Lines: 3538
Relevant Lines: 3952
💛 - Coveralls
coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 2020

Details

Totals Coverage Status
Change from base Build 2014: 0.002%
Covered Lines: 3538
Relevant Lines: 3952
💛 - Coveralls
KKKIIO commented 23 hours ago

This API can be useful for implementing efficient encoding algorithms. For example, it can help encode a String in UTF-8 or write a list of Int values without the need for multiple memory reallocations.

qazxcdswe123 commented 10 hours ago

This API can be useful for implementing efficient encoding algorithms. For example, it can help encode a String in UTF-8 or write a list of Int values without the need for multiple memory reallocations.

If you already know the size in advance, why not set the size_hint in Buffer::new?

KKKIIO commented 8 hours ago

This API can be useful for implementing efficient encoding algorithms. For example, it can help encode a String in UTF-8 or write a list of Int values without the need for multiple memory reallocations.

If you already know the size in advance, why not set the size_hint in Buffer::new?

I may have misunderstood Moonbit's Buffer.

Initially, I thought it was similar to Golang's bytes.Buffer, which often reuses the same instance during a connection and calls Reset to reset the read/write position while retaining the storage before writing a new packet.

However, Moonbit's Buffer::reset discards any grown Bytes and reuses the initial_bytes, suggesting that a sufficiently large size_hint should be provided during initialization rather than relying on lazy growth. In this context, exposing grow_if_necessary seems unnecessary.

I'm curious about the benefits of this implementation. While it may reduce extra memory usage, it also incurs a penalty every time it exceeds the size_hint. If the maximum packet size can be limited, the entire 'grow' algorithm might be unnecessary.