search

mooncake-dev / react-day-time-picker

A React component to help with scheduling a day and time.
https://react-day-time-picker.netlify.com/
MIT License
35 stars 23 forks source link

Remove "dayValidator" from public API #11

Closed danillouz closed 5 years ago

danillouz commented 5 years ago

Fixes #9

dinostheo commented 5 years ago

There is an edge case that I experienced during evening. I had a timeSlotSize in 60 minutes and it was past 23:15. The day was active and you could click it, but there were no time slots as it should. I used the dayValidator to fix that by increasing the first valid day by my timeSlotSize. Then you could see the current day bold, but not able to click it. I found that possibility nice. However, if you think that removing the dayValidator will solve/avoid other problems/complexities, then we could ignore this edge case and say that getting no time slots in a day is a valid view.

danillouz commented 5 years ago

I'll create a new issue to display a message like:

There are no available time slots. Please pick another day

Speaking of edge cases. Since we're dealing with a moving time window. A slot might "expire" when being idle. For example with 30 min. time slots. It will show up at the 29nth minute on the hour, but will remain visible when idle for 2 min. While it should not be selected. I'll create an issue for this as well.