search

moondance-labs / tanssi

GNU General Public License v3.0
116 stars 44 forks source link

Stream payment: Prevent making a request with a past deadline #598

Closed nanocryk closed 3 weeks ago

nanocryk commented 1 month ago

Prevents making a request with a mandatory change having a deadline in the past. Also fix the stream_payment_status function to return stalled = true when deadline is reached.

github-actions[bot] commented 1 month ago

Coverage Report

(master)

@@                            Coverage Diff                            @@
##           master   jeremy-steam-payment-no-past-deadline      +/-   ##
=========================================================================
+ Coverage   69.60%                                  69.61%   +0.01%     
  Files         226                                     226              
+ Lines       40210                                   40221      +11     
=========================================================================
+ Hits        27988                                   27996       +8     
+ Misses      12222                                   12225       +3
Files Changed Coverage
/pallets/stream-payment/src/lib.rs 91.01% (-0.44%) 🔽

Coverage generated Mon Jun 24 06:42:31 UTC 2024

girazoki commented 1 month ago

Thank you @nanocryk , let's fix dev tests and merge