moondance-labs / tanssi

GNU General Public License v3.0
116 stars 44 forks source link

Change Registrar balances reserves to holds and migration #606

Closed fgamundi closed 1 day ago

fgamundi commented 3 weeks ago

Change the balance deposit when registering a container chain from Currency's reserve to fungible's hold. Migration to existing deposit also included

github-actions[bot] commented 3 weeks ago

Coverage Report

(master)

@@                  Coverage Diff                   @@
##           master   fg-registrar-holds      +/-   ##
======================================================
+ Coverage   67.25%               67.32%   +0.07%     
  Files         255                  255              
+ Lines       44273                44448     +175     
======================================================
+ Hits        29772                29922     +150     
+ Misses      14501                14526      +25     
Files Changed Coverage
/container-chains/runtime-templates/frontier/src/lib.rs 58.63% (-0.31%) 🔽
/container-chains/runtime-templates/simple/src/lib.rs 71.38% (-0.92%) 🔽
/pallets/registrar/src/lib.rs 88.86% (-0.01%) 🔽
/runtime/common/src/migrations.rs 88.65% (+0.73%) 🔼
/runtime/dancebox/src/lib.rs 88.81% (+0.19%) 🔼
/runtime/dancebox/tests/integration_test.rs 99.71% (+0.01%) 🔼
/solo-chains/runtime/starlight/src/lib.rs 19.88% (+0.14%) 🔼

Coverage generated Fri Jul 19 15:57:15 UTC 2024

girazoki commented 1 day ago

The PR looks good to me

@nanocryk can you review it since you have touched holds?