search

moondance-labs / tanssi

GNU General Public License v3.0
226 stars 48 forks source link

Add author-noting to starlight and make it generic over para/relay #618

Closed tmpolaczyk closed 2 months ago

tmpolaczyk commented 3 months ago

Adds a RelayOrPara config type that can be set to ParaMode or RelayMode. In relay mode we still use an inherent, but instead of passing the storage proof to the inherent, we pass () and read the storage directly using the NativeStorageReader.

github-actions[bot] commented 2 months ago

Coverage Report

(master)

@@                        Coverage Diff                         @@
##           master   tomasz-starlight-author-noting      +/-   ##
==================================================================
+ Coverage   66.88%                           66.89%   +0.01%     
  Files         255                              255              
+ Lines       44587                            44695     +108     
==================================================================
+ Hits        29819                            29897      +78     
+ Misses      14768                            14798      +30
Files Changed Coverage
/pallets/author-noting/src/lib.rs 87.76% (-0.37%) 🔽
/pallets/author-noting/src/weights.rs 58.62% (+22.41%) 🔼
/primitives/traits/src/lib.rs 84.09% (+1.59%) 🔼
/solo-chains/runtime/starlight/src/lib.rs 20.00% (+0.12%) 🔼
/solo-chains/runtime/starlight/tests/common/mod.rs 95.28% (+4.97%) 🔼

Coverage generated Tue Jul 30 07:43:40 UTC 2024

girazoki commented 2 months ago

@tmpolaczyk maybe we can merge back master after you made it more consistent?