search

moonglow / FlashForge_Marlin

:shark: Marlin firmware for FlashForge Dreamer/Dreamer NX/Inventor, Bosch Dremel 3D20 3D, PowerSpec Ultra 3D and Monoprice Inventor 1
84 stars 26 forks source link

sdio_stm32duino.cpp has been removed from upstream Marlin, make DIGIPOT settings more flexible #95

Closed Mrnt closed 2 years ago

Mrnt commented 2 years ago
moonglow commented 2 years ago

Hi @Mrnt !

Hm... did your sure about SDIO driver ? HERE

About DIGIPOT yeap i like that idea i think we need to make pull request to official Marlin repo with that feature, because it useful for other users too. But defines needs to make both uppercase as it used in other marlin configs !

Mrnt commented 2 years ago

Hm... did your sure about SDIO driver ? HERE

If you enable SDIO_SUPPORT you will get a build error because of multiple definitions of SDIO functions. If you look at the current Master branch of Marlin they have removed Sd2Card_sdio_stm32duino.cpp, and added a replacement SDIO driver Jan 8: https://github.com/MarlinFirmware/Marlin/commits/2.0.x/Marlin/src/HAL/STM32/sdio.cpp

About DIGIPOT yeap i like that idea i think we need to make pull request to official Marlin repo with that feature, because it useful for other users too. But defines needs to make both uppercase as it used in other marlin configs !

I was surprised Marlin did not do that already. Seems unlikely that every driver would have the same exact circuit. They use mixed case in their file. I will have a go at making a pull request on the official repo.

Mrnt commented 2 years ago

BTW, thank you for doing this project. I had made an OctoPrint plugin for these printers but even though it works, it is not reliable - the FlashForge firmware does not seem to behave in a consistent, predictable fashion. And it is of course, an opaque, black box of closed source.

moonglow commented 2 years ago

you will get a build error because of multiple definitions of SDIO functions.

Ah... that's my fault sorry i forgot. Thanks for your tips. Looks like something goes wrong when i apply previous merge ^_^

I was surprised Marlin did not do that already.

Totally agree

They use mixed case in their

Yep , but it looks ugly :)

BTW, thank you for doing this project.

You are welcome i hope it be useful for many users and bring new life to their printers :+1:

black box of closed source.

Their base firmware is port of Sailfish with GUI from Segger ,but they did not wants to open their modifications and that's sad, yep.... who needs outdated or feature less firmware ...