search

moonheart / mementomori-helper

メメントモリ MementoMori 游戏助手 Game Assistant ゲームアシスタント
GNU Lesser General Public License v2.1
63 stars 11 forks source link

fix event and notice fetching based on selected language #83

Closed Veirt closed 2 months ago

Veirt commented 2 months ago

Changes made:

  1. Modified event and notice fetching to use the selected language from the dropdown menu. Previously, it only fetched events and notices in Chinese, no matter what the selected language is.

  2. Implemented automatic fetching of events and notices when: a) Initially loading the website b) Changing the language in the dropdown menu

Here's a preview video of the changes:

https://github.com/moonheart/mementomori-helper/assets/55097092/6964ae55-e3c3-4b1a-8455-b58fd86cac5e

I'm making this pull request to bring attention to a bug I noticed and to propose a potential fix. As I've never used C# and Blazor before this project, I recognize there might be more efficient or idiomatic ways to achieve this.

Feel free to close this pull request if you don't find my changes suitable or if you prefer to address the issue differently.

Thank you.

moonheart commented 2 months ago

Hello Veirt,

Thank you so much for your pull request. I truly appreciate your effort. I've added some comments for your review. Please take a look when you get a chance.

Best regards, moonheart

Veirt commented 2 months ago

Thanks! Really appreciate you taking the time to go through the code and leave those comments.