moonlight-stream / moonlight-android

GameStream client for Android
GNU General Public License v3.0
3.89k stars 616 forks source link

[Issue]: Does not fully respect custom keyboard layout #1382

Closed ClassicOldSong closed 1 month ago

ClassicOldSong commented 2 months ago

Describe the bug

When the connected physical keyboard is set to a different layout, the modified layout is not fully respected.

Steps to reproduce

  1. Connect a physical keyboard, change it to a different layout like dovark/colemak
  2. Type using the keyboard in normal android applications to see if it's typing using the correct layout
  3. Type to the connected sunshine server and you'll find some keys are mapped correctly, some are totally not affected.

Affected games

ANY

Other Moonlight clients

PC

Moonlight adjusted settings

No

Moonlight adjusted settings (please complete the following information)

none

Moonlight default settings

Yes

Gamepad-related connection issue

No

Gamepad-related input issue

Yes

Gamepad-related streaming issue

No

Android version

Android 14

Device model

OnePlus Pad Pro

Server PC OS version

Windows 11 23H2

Server PC GeForce Experience version

-

Server PC Nvidia GPU driver version

-

Server PC antivirus and firewall software

-

Screenshots

No response

Relevant log output

No response

Additional context

No response

ClassicOldSong commented 1 month ago

Fixed myself.

Will submit a PR once the code is cleaned.

Download prebuilt at https://github.com/ClassicOldSong/moonlight-android/releases

ClassicOldSong commented 1 month ago

Closing this issue since "you fixed the issue you opened doesn't necessarily mean others have the same issue", "you fixed your problem but might break every else" and "Either be patient or go away".

What a drama in the discord server!

Getting kicked for helping people out when the main project has no updates and no message about updates for months.

Sure, I'll go away, no more PRs to help people actually in need and I still wish good luck to you.