search

moonlight-stream / moonlight-android

GameStream client for Android
GNU General Public License v3.0
3.9k stars 616 forks source link

[Issue]: sendControllerBatteryPacket still blocks input event firing #1389

Closed ClassicOldSong closed 1 month ago

ClassicOldSong commented 1 month ago

Describe the bug

Controller battery updating can still be blocking any input event callbacks for quite a long time.

Steps to reproduce

  1. Start a stream, test pen input with a stylus
  2. Connect a controller or press a key on the controller
  3. The pen stops responding for quite some time, touch/keyboard input also stops working

Affected games

ANY

Other Moonlight clients

PC

Moonlight adjusted settings

No

Moonlight adjusted settings (please complete the following information)

Moonlight default settings

Yes

Gamepad-related connection issue

Yes

Gamepad-related input issue

Yes

Gamepad-related streaming issue

Yes

Android version

Android 14

Device model

OnePlus Pad Pro

Server PC OS version

Windows 11 23H2/Linux 6.1

Server PC GeForce Experience version

-

Server PC Nvidia GPU driver version

-

Server PC antivirus and firewall software

-

Screenshots

No response

Relevant log output

No response

Additional context

No response

ClassicOldSong commented 1 month ago

Seems related to Android framework. No actual fix can be done app-side.

Work around by adding an option to disable battery status report: https://github.com/ClassicOldSong/moonlight-android/releases/tag/v12.1-240714-NIOR

Will sumpit a PR later.

ClassicOldSong commented 1 month ago

Closing this issue since "you fixed the issue you opened doesn't necessarily mean others have the same issue", "you fixed your problem but might break every else" and "Either be patient or go away".

What a drama in the discord server!

Getting kicked for helping people out when the main project has no updates and no message about updates for months.

Sure, I'll go away, no more PRs to help people actually in need and I still wish good luck to you.