moonlight-stream / moonlight-chrome

GameStream client for ChromeOS
GNU General Public License v3.0
740 stars 166 forks source link

Since most recent GeForce Experience update certain buttons not working #223

Closed nicholson101 closed 7 years ago

nicholson101 commented 7 years ago

Since I've updated to 3.5.0.70 I'm unable to use ctrl, shift and Alt in games. All other keys seem to be working fine. I've reinstalled both moonlight and GF experience to no success and also tried a different keyboard.

cemarriott commented 7 years ago

Having the same issue. I find that if I repeatedly hit one of those keys that it will eventually fire. However the keys can't be sustained, they fire once quickly as though they were pressed and released, even if you are holding the key down.

On Apr 12, 2017, at 8:12 AM, nicholson101 notifications@github.com wrote:

Since I've updated to 3.5.0.70 I'm unable to use ctrl, shift and Alt in games. All other keys seem to be working fine. I've reinstalled both moonlight and GF experience to no success and also tried a different keyboard.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

nicholson101 commented 7 years ago

Exactly this! Playing Just Cause 3 when trying to start up the helicopters engine, if i repeatedly press shift (rotors) the rotors spin for a second and then stop.

jimb0616 commented 7 years ago

I'm having the same exact issue and it's happening with my "shift" key, and a few others. Such a pain!!

jimb0616 commented 7 years ago

It seems the keys that are used to close the stream (ctrl+alt+shift+Q) are the ones not working right. Well, Q works fine but not the others. And it's only in-game they don't work. When streaming the desktop or chatting in game they work fine.

Banana-In-Black commented 7 years ago

Yes, I have the exactly the same issue. You can't long press alt / ctrl / shift.

WidgetPhreak commented 7 years ago

It would appear that what is happening, since the latest nVidia update, is that now the CTRL, ALT, and SHIFT keys are registering a "Held Keypress" as a "Rapid Fire". Example: In Overwatch... as Soldier 76... you Hold LEFT_SHIFT to Sprint. You Hold CTRL to Crouch/Duck. After the Recent update... Holding LEFT_SHIFT while walking causes the Sprint to go ON/Off/ON/Off/On/OFF. If you hold CTRL to Crouch... you basically end up "Tea-Bagging" (crouch crouch crouch crouch crouch).

In GTA Online... Holding Shift is Also a Sprint... Same thing Happens. CTRL lets you do Wheelies on Motorcycles... and it lets you Tilt Helicopters. But with the Current Bug... it's basically impossible to control a Helicopter... a riding a Motorcycle is problematic... because you need wheelies so the Bike and launch over Rocks/Obstacles... rather can crashing.

airdjing commented 7 years ago

Same issues here

nicholson101 commented 7 years ago

I feel this has rendered the current version unusable for now as almost all games require shift/ctrl/alt. The only way would be to roll back Geforce experience to the previous version and prevent it from updating for the time being.

ShadowBullet commented 7 years ago

Okay everyone, I have compiled a version of Moonlight that it current with all current Commits, I found that Game Box Artwork works again so that is a good thing, let me know if this possibly fixes any of the issues described in this thread. I have posted a link to the compiled version down below, just follow the standard install instructions as in previous releases.

https://drive.google.com/open?id=0B4igNzfYt4TzMkZMMHFTLXBpdzg

WidgetPhreak commented 7 years ago

I know the official stance on this is probably "we don't support it any more", but... Any chance of getting an updated version of the .jar [java based] client?

I've found it to be consistently more reliable than the Chrome Version when I stream from my Home network to my Laptop at work. [example... on the Chrome Version... if I disconnect... I can't reconnect again until I reboot the Windows PC... but with the Java version... I can disconnect/reconnect as much as I want...

I've even found that If the Chrome Version won't connect... the Java version will... and by connecting with the Java Version... and then Disconnecting... the Chrome Version will connect again].

ShadowBullet commented 7 years ago

Can confirm that the issues described in this thread are still happening in the release that I compiled. @raidancampbell @cgutman any ideas to patch a quick fix for it so we can continue to use Moonlight?

WidgetPhreak commented 7 years ago

I can confirm... the new .crx posted above still exhibits the same issues with CTRL, ALT, and SHIFT. I've uploaded a video example of what's going on... on the off chance it will help the developers. Local Keyboard VS Moonlight using latest nVidia Updates

xxblindmonkeyxx commented 7 years ago

I have rollee back to 3.3 and the issue persists??

nicholson101 commented 7 years ago

I have rolled back one version and it is working perfectly fine for me for the time being.

xxblindmonkeyxx commented 7 years ago

My fault it had auto updated again. How do you stop that?

nicholson101 commented 7 years ago

I think I've figured that part out as it auto updated on me too. In "program data/Nvidia corporation/downloader" i renamed setup to something random. I haven't fully tested this yet but i believe this works. Make sure you do this as soon as you have installed the desired version.

WidgetPhreak commented 7 years ago

No such luck for me. I manually removed everything nvidia related from my machine via add/remove programs... and tried several different old versions of the drivers and the nvidia experience... I even went as far back as using the April 2016 drivers from the CDROM that shipped with my GFX card... and told them not to auto update. Problem Persists.

nicholson101 commented 7 years ago

So the key presses aren't registering with any version for you!?

WidgetPhreak commented 7 years ago

They've always registered. The problem is... that since the update (and attempted rollbacks) CTRL ALT & SHIFT "Rapid Fire" when Held, rather then just registering a Long Press/Press and Hold.

nicholson101 commented 7 years ago

That's a new one on me!? I'm getting no button recognition on ctrl/shift/alt at all. Long or rapid press.

jimb0616 commented 7 years ago

I'm shocked that the dev of moonlight-streaming hasn't published an update since the last one. I'm hoping this can be resolved without having to rollback nVidia drivers. For now, I'm using CAPSLOCK as my sprint and steady scope buttons, in place of shift.

On Tue, Apr 18, 2017 at 4:57 PM, nicholson101 notifications@github.com wrote:

That's a new one on me!? I'm getting no button recognition on ctrl/shift/alt at all. Long or rapid press. Hi

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-chrome/issues/223#issuecomment-294980262, or mute the thread https://github.com/notifications/unsubscribe-auth/AMKaV6POscnUJh4s3ygkK10n6405jhENks5rxSOlgaJpZM4M7Vl3 .

jimb0616 commented 7 years ago

Though it's related to the nVidia GFE update, the dev has usually been on top of fixes and publishing updates... especially for big issues like this one.

The last thing I want to do is turn on my VPN again to use Steams in-home streaming. The keys work fine, but the quality is far less than moonlight-streaming.

nicholson101 commented 7 years ago

my above fix for stopping geforce experience from updating has not worked. My only option at the moment is to remote in to my PC via teamviewer and uninstall the most recent version and then install the previous version making sure the window stays open (preventing it from updating) on first open....

Every. Single. Time..... :-(

ShadowBullet commented 7 years ago

Okay, if anyone knows how to code at all lines 37-52 in the input.cpp file seems to be were it takes in the input of the SHIFT, CTRL, ALT keys. If we can change that and possibly make our own branch of the project then maybe we might be able to fix it. @raidancampbell @cgutman @dead Still holding out hope that possibly one of you guys might be able to assist us.

For those wondering here is the link to the input.cpp file https://github.com/moonlight-stream/moonlight-chrome/blob/master/input.cpp

And here is line 32-57 just in case you don't want to go to the link

static char GetModifierFlags(const pp::InputEvent& event) { uint32_t modifiers = event.GetModifiers(); char flags = 0;

if (modifiers & PP_INPUTEVENT_MODIFIER_SHIFTKEY) {
    flags |= MODIFIER_SHIFT;
}
if (modifiers & PP_INPUTEVENT_MODIFIER_CONTROLKEY) {
    flags |= MODIFIER_CTRL;
}
if (modifiers & PP_INPUTEVENT_MODIFIER_ALTKEY) {
    flags |= MODIFIER_ALT;
}

return flags;

}

ShadowBullet commented 7 years ago

Okay everyone I have good news and bad news, the good news is issue is most likely not with Moonlight (WOOHOO!) The issues is possibly with GFE itself, check forum here https://forums.geforce.com/default/topic/1000847/gamestream/everything-was-fine-yesterday-now-ctrl-shift-alt-no-longer-works-when-gamestreaming/

ShadowBullet commented 7 years ago

Possibly may still have to update Moonlight however just saw that they updated Shield Hub and they said they pushed an update to that that may have fixed it, so we may still need an updated version of Moonlight. @cgutman @raidancampbell @dead PLEASE HELP US YOUR OUR ONLY HOPE

WidgetPhreak commented 7 years ago

If the GFE update broke nVidia's Official Shield software too, and their fix involved an update to the Shield, and not the GFE... Moonlight will require an update for sure. If they had opted for an additional update to the GFE to resolve the issue... we could have waited for that. But it looks like nVidia has done all they are gonna do (patch their official Shield Devices). Since our Shield solution is Moonlight... the devs or community will have to provide our solution.

cgutman commented 7 years ago

I'm aware of the issue and have tried several ways to workaround it, but without much luck.

As far as I'm concerned, the jury is still out on whether this is a GFE or Moonlight/Shield issue. My Shield has no option to update to the version mentioned in that forum thread, so some Shield folks are dead in the water too.

APKMirror also has no record of the build they're saying will fix the issue: https://www.apkmirror.com/apk/nvidia/nvidia-games/

That's not to say it's not out there, but they've at least botched the deployment of it somehow. Without being able to peek at what Shield Hub is doing, this won't get fixed soon.

ShadowBullet commented 7 years ago

Well at least it is on both platforms then, hopefully NVIDIA will issue a hotfix through GFE and fix it for everyone. Also @cgutman any chance that once this is resolved perhaps if you are willing to/have time for it, would you consider updating the project a little bit more? I know it is still in an alpha state, and since chrome apps are going out the wayside perhaps we need to come up with a permanent solution for Moonlight on the PC. Any ideas on what such development might transpire from this? Also thank you very much for weighing in on this issue. I know that it means a lot to us when you respond to inquiries and bugs such as this thread and I think I speak for everyone when I say that.

cgutman commented 7 years ago

At this point, I'm not sure what the future of Moonlight on the PC will be. We tried to kill Java and replace it with Chrome to reduce our support work, but now we really just have twice the PC clients with different quirks to maintain.

The best path forward is probably (yet another) rewrite but this time in C++ with Qt. We can be pretty sure that's not going away any time soon ;)

nicholson101 commented 7 years ago

It would be a shame to leave the PC client of the list of options. I have a shield portable and a shield TV but still use the PC client the most!

TheNferno commented 7 years ago

In regards to cgutmans response about the future of Moonlight, I really like the chrome client as it allows me to use my chrome book as well as use Moonlight on computers where I do not have admin access. I understand the longevity that comes with the C++ rewrite but I really like the functionality of the chrome client. BTW, all I know to write in is HTML and really basic Flash so please educate me if make wrong assumptions

ApexAftermath commented 7 years ago

Same issue here. I hope nvidia fixes the issue on their end as it seem the problem comes from GFE.

ShadowBullet commented 7 years ago

Okay guys, 13 hours ago (at the time of writing this) a mod over at the NVIDIA forums commented again on that forum I had posted a bit ago. (link in case you forgot: https://forums.geforce.com/default/topic/1000847/gamestream/everything-was-fine-yesterday-now-ctrl-shift-alt-no-longer-works-when-gamestreaming/) Hopefully once the update drops we cna get a patch fix for Moonlight so it can go back to a working state.

minnux commented 7 years ago

Just commenting to see if there's any kind of time table yet for an update to this problem. Or is this solely contingent on Nvidia pushing a new update for GFE and we're just waiting on them?

cgutman commented 7 years ago

We need either a GFE update to fix the issue or a Shield Hub update to see how they fix it.

minnux commented 7 years ago

Thanks for the quick reply. I will go check with Nvidia and see if there's any update time table.

jimb0616 commented 7 years ago

Can't we just extract the code from their latest update and configure it then input to MLS?

On Apr 28, 2017 3:25 PM, "minnux" notifications@github.com wrote:

Thanks for the quick reply. I will go check with Nvidia and see if there's any update time table.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-chrome/issues/223#issuecomment-298085963, or mute the thread https://github.com/notifications/unsubscribe-auth/AMKaVw-HnZ_P31pv9-hFPW_U7eaUmwAWks5r0j07gaJpZM4M7Vl3 .

cgutman commented 7 years ago

That's much easier said than done.

jimb0616 commented 7 years ago

I realize that, but it is possible. I wish I had the time to do it myself but I don't.

On Apr 28, 2017 8:43 PM, "Cameron Gutman" notifications@github.com wrote:

That's much easier said than done.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-chrome/issues/223#issuecomment-298135792, or mute the thread https://github.com/notifications/unsubscribe-auth/AMKaV_WEy7BzEI8R_bSPfe8_quUqy_TNks5r0oe9gaJpZM4M7Vl3 .

nicholson101 commented 7 years ago

If it will tip Nvidia's hand, can we all keep the above thread alive on the geforce forums so that they take notice?

cgutman commented 7 years ago

This is fixed in GFE Beta 3.6.0.74.

Open GFE, go to settings, and check the "Allow experimental features" box. Give it a couple minutes to download in the background, then restart GFE and it should prompt you for the update.

jimb0616 commented 7 years ago

Thanks for the info!

On May 4, 2017 12:26 PM, "Cameron Gutman" notifications@github.com wrote:

This is fixed in GFE Beta 3.6.0.74.

Open GFE, go to settings, and check the "Allow experimental features" box. Give it a couple minutes to download in the background, then restart GFE and it should prompt you for the update.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-chrome/issues/223#issuecomment-299237750, or mute the thread https://github.com/notifications/unsubscribe-auth/AMKaV1BThvmE1EnbkmUdDdg9Uq2Qg_96ks5r2fw0gaJpZM4M7Vl3 .

Ononeemas commented 5 years ago

Same issue. I've set caps lock on "toggle mute" option in geforce expirience in-game overlay and then caps lock stopped working at all, only indicator lightning at keyboard continued to switch w/o any effect. It took 30mins to realize what's wrong.