Add MODIFIER_KEYPAD flag

moonlight-stream / moonlight-common-c

Core implementation of Nvidia's GameStream protocol

GNU General Public License v3.0

448 stars 166 forks source link

Add MODIFIER_KEYPAD flag #34

Closed kevincharm closed 6 years ago

kevincharm commented 6 years ago

Please see: https://github.com/moonlight-stream/moonlight-chrome/pull/348

cgutman commented 6 years ago

How did you find that this modifier flag is needed? It seems to work fine without it as long as you send the right keycodes.

kevincharm commented 6 years ago

It isn't needed after fixing the keycodes on the client side, but I tried to implement the fix with the least amount of changes to the code.

cgutman commented 6 years ago

Ah, I see. You're just using it internally in moonlight-stream/moonlight-chrome#348 to indicate that the keycode needs conversion. Yeah, let's not pollute moonlight-common-c with client-specific definitions that aren't required by the protocol.