search

moonlight-stream / moonlight-common-c

Core implementation of Nvidia's GameStream protocol
GNU General Public License v3.0
458 stars 167 forks source link

Added support of HEVC encoded by AMF toolkit from AMD #56

Closed GNUDimarik closed 3 years ago

GNUDimarik commented 3 years ago

I working on support of AMD hw encoding in openstream app and this fix needs for handling HEVC encoded by hw encoder.

hevc

cgutman commented 3 years ago

I committed a change that should address this problem (though I couldn't test it).

Please try again with 8b1fbc770e6b4b5ac04a577196b106953842aa15 and let me know if that works for you.

GNUDimarik commented 3 years ago

I've read the specification and wanted to continue :-) Will try it and let you know

вс, 28 мар. 2021 г., 21:35 Cameron Gutman @.***>:

I committed a change that should address this problem (though I couldn't test it).

Please try again with 8b1fbc7 https://github.com/moonlight-stream/moonlight-common-c/commit/8b1fbc770e6b4b5ac04a577196b106953842aa15 and let me know if that works for you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-common-c/pull/56#issuecomment-808913232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPDTI65Z3FLS7UVWQGORG3TF5ED7ANCNFSM4ZYO3IRA .

cgutman commented 3 years ago

Are you seeing these AUD NALs on AMF H.264 too, or just HEVC?

GNUDimarik commented 3 years ago

Are you seeing these AUD NALs on AMF H.264 too, or just HEVC?

At the moment hevc only. I'm just started deep understanding of the codecs. Reading the spec firstly :-) Let me check your commits

GNUDimarik commented 3 years ago

Doesn't work. I see black screen. Please give me some time. I'll fix that and update pull request today

GNUDimarik commented 3 years ago

Are you seeing these AUD NALs on AMF H.264 too, or just HEVC?

At the moment hevc only. I'm just started deep understanding of the codecs. Reading the spec firstly :-) Let me check your commits

H264 is next step

GNUDimarik commented 3 years ago

sorry for confusion. With your commit the both h264 and hevc encoded by AMF are working. Thanks a lot!

cgutman commented 3 years ago

Great! Feel free to file issues if there are other interoperability issues with OpenStream.

GNUDimarik commented 3 years ago

Thanks a lot. I appreciate it. Will share in future some stuff related with opensrream AMF encoding. As currently I've bad but working solution.