search

moonlight-stream / moonlight-common-c

Core implementation of Nvidia's GameStream protocol
GNU General Public License v3.0
458 stars 167 forks source link

BT.709 and full color range by default #71

Closed skbeh closed 2 years ago

skbeh commented 2 years ago

Nowadays, almost all clients are using BT.709 and full color range, and the network usage should be acceptable. Maybe compatibility of color range was a thing when the library was created, but now every modern tv is able to show contents with full RGB range. I think it is time to change the defaults.

cgutman commented 2 years ago

Those defaults come from NVIDIA GameStream itself (specifically the encoderCsc SDP value, which defaults to 0 meaning BT.601 limited range).

I likely won't be changing those here due to compatibility reasons, but clients are free to request whatever colorspace and color range they would like using the colorSpace and colorRange fields in STREAM_CONFIGURATION.

skbeh commented 2 years ago

Ok, I think it would be better to discuss it in the moonlight client repos rather than the library.