moonlight-stream / moonlight-embedded

Gamestream client for embedded systems
https://github.com/moonlight-stream/moonlight-embedded/wiki
GNU General Public License v3.0
1.5k stars 325 forks source link

Cannot launch non-steam games if filename has spaces in it #699

Open wonx opened 5 years ago

wonx commented 5 years ago

I manually added a few non-steam games to my game list. I can run them from steam, either in desktop or in big picture view, and they launch and work. However, when I use moonlight from my raspberry pi, and I launch the same game from the Big Picture view, I get an error for those games who have a space in their filename.

For instance: Launching "C:\Program Files\Dolphin\Dolphin.exe" /e "V:\Gamecube\Mari Kart - Double Dash!! (USA).iso" Does not work. Launching "C:\Program Files\Dolphin\Dolphin.exe" /e "V:\Gamecube\The_Legend_Of_Zelda_The_Wind_Waker_USA_NGC-STARCUBE.iso" Works just fine.

I also tried with other games and other emulators, and it is consistent. On the other hand, spaces on the path to the game do not cause any issues.

Please provide the following info.

NVidia Geforce Experience version: 3.15.0.186 Moonlight Embedded version: Moonlight Embedded 2.4.7 Moonlight Embedded source: Used the script in https://github.com/TechWizTime/moonlight-retropie Moonlight Embedded running on: Raspberry Pi 3 Moonlight Embedded running on distribution: Linux retropie 4.4.50-v7+ in Raspbian GNU/Linux 8

suniastar commented 5 years ago

You could use this simple workaround and stream the entire desktop:

This is how I use moonlight myself every time and it works perfectly fine.

wonx commented 5 years ago

But then it would just show Windows' desktop? How could I launch the steam from there using a game controller?

suniastar commented 5 years ago

Could you provide the command you used to start moonlight on your raspberry and the error message thrown by moonlight when you are using spaces?

wonx commented 5 years ago

I use this command to start moonlight on the raspberry: moonlight stream -720 -fps 30 192.168.1.121

This is the command used in Steam to launch the game: "C:\Program Files\Dolphin\Dolphin.exe" /e "V:\Wii\SUPER MARIO GALAXY.iso"

And his is the error message I get when I launch it from moonlight: https://imgur.com/a/aIu5akz

suniastar commented 5 years ago

So thats not a moonlight problem. Seems like a Dolphin Problem. I dont know what Dolphin does or what it is but i suggest to rename the .iso files.

wonx commented 5 years ago

The same happens with any other path that includes spaces, not only Dolphin. For instance, if you try to launch a PS2 game using PCSX2.

The thing is that the launcher works just fine from Steam, but not if you start it from Moonlight.

suniastar commented 5 years ago

Ok but when I get that correctly launching moonlight without an -app Option will automatically start Steam Big Picture Mode.

So everything that happens from now on is not affected by moonlight anymore. Moonlight only starts the video stream and launches a .exe in this case steam (Big Picture). Plus The error message in your images is returned by Dolphin not by moonlight so this has to be a Problem on your Windows machine.

So I would still recommend to rename the .iso files.

You could also try this:

Then repeat those steps for every file you need this for.