moonlight-stream / moonlight-embedded

Gamestream client for embedded systems
https://github.com/moonlight-stream/moonlight-embedded/wiki
GNU General Public License v3.0
1.5k stars 325 forks source link

Improve code consistency and readability #718

Closed hhromic closed 5 years ago

hhromic commented 5 years ago

Description This PR does not change any functionality, but it improves code consistency and readability. Two main changes are proposed:

  1. The action modifiers constants QUIT_MODIFIERS and MODIFIERS in input/{evdev,x11}.c respectively are renamed to ACTION_MODIFIERS as it is in input/sdl.c, so these are consistently named across all three input drivers.
  2. A new QUIT_KEY constant is added to input/x11.c and used instead of the direct key code for readability. This constant name is also consistent across all three input drivers.

Purpose Make the codebase more consistent, readable and clean, hence better to maintain and work with. I plan to bring some new functionality and cleaning up the code helps to have less clutter in future. I hope this can be merged soon. Thanks!