search

moonlight-stream / moonlight-embedded

Gamestream client for embedded systems
https://github.com/moonlight-stream/moonlight-embedded/wiki
GNU General Public License v3.0
1.49k stars 324 forks source link

optionally skip stages in omx cleanup. #774

Closed aandaluz closed 1 year ago

aandaluz commented 4 years ago

Description Optinal Fix decoder hangups reported in #763 Purpose Add an optimal preprocessor definition #SKIP_OMX_CLEANUP (controlled by a cmake option) if we generate the project with cmake p cmake ../<source_code_dir> -DSKIP_OMX_CLEANUP then the SKIP_OMX_CLEANUP symbol will be defined and some omx decoder methods will not be called during cleanup. This fixe our decoder freezing issues with GFE 3.17 that we reported in #763 . Since this is a dirty workaround for us, we have decided not to enable it by default and leave current behaviour as is. If nobody reports any drawbacks, it would be interesting to have it on by default.

aandaluz commented 1 year ago

Closing this PR due to lack of feedback. We will keep updating our custom fork with this patch in the meantime.

cgutman commented 1 year ago

I would suggest using MMAL instead of OMX on the Raspberry Pi. I don't believe OMX decoding code on the Pi is actively maintained anymore.