search

moonlight-stream / moonlight-embedded

Gamestream client for embedded systems
https://github.com/moonlight-stream/moonlight-embedded/wiki
GNU General Public License v3.0
1.48k stars 322 forks source link

Any plan to add hdr support? #858

Open benzhe opened 1 year ago

benzhe commented 1 year ago

Please provide the following info.

NVidia Geforce Experience version: Moonlight Embedded version: Moonlight Embedded source: repository/included in distribution/compiled from source/... Moonlight Embedded running on: Raspberry Pi/Cubox-i/Hummingboard/Other linux device/... Moonlight Embedded running on distribution: Arch Linux/Raspbian/OpenELEC/...

Verbose output -verbose of Moonlight Embedded:

What is the expected result?

What happens instead of that?

cgutman commented 1 year ago

The core code for HDR should be pretty trivial. The challenge is supporting the various video backends and testing on HDR-capable hardware.

What platform are you looking for HDR support for?

benzhe commented 1 year ago

Sorry for the late response. I am using a moonlight-embedded build named Luna for CoreELEC, which is based on Kodi for Amlogic hardware. Amlogic devices have a high market share in the TV media box, and it seems most TV released these years have HDR features.

https://github.com/TheChoconut/Luna

cgutman commented 1 year ago

I introduced the basic HDR plumbing with c2f21b955d4d2dcccbf165c791db151024c24186 which enables HDR with the -hdr option.

On the Amlogic side, it looks like amcodec does most of the heavy lifting for HDR. I was able to successfully enter HDR mode on a Vero 4K with the latest code in master.

Which Amlogic device are you using?

benzhe commented 1 year ago

I introduced the basic HDR plumbing with c2f21b9 which enables HDR with the -hdr option.

On the Amlogic side, it looks like amcodec does most of the heavy lifting for HDR. I was able to successfully enter HDR mode on a Vero 4K with the latest code in master.

Which Amlogic device are you using?

That's cool! I will try it later. And my device is TX3, with S905x3 SOC.

benzhe commented 1 year ago

Hi @TheChoconut , can you merge this commit into your fork? This request may seem weird since I found my compilation buggy on CoreELEC.