moonlight-stream / moonlight-qt

GameStream client for PCs (Windows, Mac, Linux, and Steam Link)
GNU General Public License v3.0
9.37k stars 550 forks source link

Wide gamut not working between Windows host and MacOS client #1213

Open stfm1973 opened 4 months ago

stfm1973 commented 4 months ago

If I use a wide gamut monitor with the correct colour settings on both the host and client (Windows host, MacOS client) the colours are very muted in the Moonlight remote desk. It looks like an sRGB monitor, but acts like a wide gamut one in colour managed applications, resulting in subdued colours.

Moonlight left, MacOS right, (you need a wide gamut monitor to see the differences) Dell Host and Client

If I use sRGB on the Windows host it works like a proper sRGB monitor in Moonlight, but then the colours on the actual host's monitor will of course be wrong, and it isn't a wide gamut monitor in Moonlight.

Moonlight left, MacOS right, (you need a wide gamut monitor to see the differences) sRGB Host

If I use sRGB on the MacOS client, and keep the Windows host colour managed, it looks about right in the Moonlight remote desktop, but wrong in the MacOS desktop. (This screenshot isn't showing how it looks on the screen. The MacOS window is extremely vibrant in reality, and the Moonlight one is correct)

Moonlight left, MacOS right, set colours to sRGB to see how it looks (you need a wide gamut monitor to see the differences) sRGB Client

Using a forced unmanaged display in Moonlight should fix the problem? Adobe uses it's own colour management, so I assume it can be done.

Foul-Tarnished commented 4 months ago

Did you try to use https://github.com/itsmikethetech/Virtual-Display-Driver ? on the host Make sure you install the HDR one, add your resolutions in the ini as stated too, and enable HDR and extend to this monitor in display settings, and disconnect/turn off your real host monitor.

HDR seems to works more or less on Macbook M3 internal display (no color banding in windows settings for example, but it seems a bit too bright ? windows thinks it's a 600nits monitor and not 1600 nits, also not sure it knows it's a DCI-P3 gamut display)

Originalimoc commented 4 months ago

I also think HDR/BT.2020 streaming is the solution. Since the SDR video stream IS a BT.709 stream the macOS is just doing its job to manage it...

stfm1973 commented 3 months ago

I lost track of this post, sorry.

Thanks! I have tried the virtual driver, and I will probably use it because I can have the real monitor turned off. But it didn't do anything to the colour handling. Using HDR didn't work at all for me, I got completely blown out highlights. It just makes a standard monitor, so I guess it wouldn't make sense that it would work any different from a real monitor.

Did you try to use https://github.com/itsmikethetech/Virtual-Display-Driver ? on the host Make sure you install the HDR one, add your resolutions in the ini as stated too, and enable HDR and extend to this monitor in display settings, and disconnect/turn off your real host monitor.

HDR seems to works more or less on Macbook M3 internal display (no color banding in windows settings for example, but it seems a bit too bright ? windows thinks it's a 600nits monitor and not 1600 nits, also not sure it knows it's a DCI-P3 gamut display)

Originalimoc commented 3 months ago

"completely blown out highlights". Your client is not setup correctly. HDR not enabled?

stfm1973 commented 3 months ago

"completely blown out highlights". Your client is not setup correctly. HDR not enabled?

I don't know, I don't have an HDR monitor on either side. On Macos there's no setting for it, as far as I know?

Originalimoc commented 3 months ago

"completely blown out highlights". Your client is not setup correctly. HDR not enabled?

I don't know, I don't have an HDR monitor on either side. On Macos there's no setting for it, as far as I know?

I have no Mac but MacOS ver has no this? If so I guess due to different Graphical API it's not implemented yet. image

Foul-Tarnished commented 3 months ago

Moonlight client on MacOS has the HDR setting...

btw, if you switch HDR on/off on windows side while using moonlight (with hdr), the colors will looks really bad and blueish, but quitting and relaunching moonlight fix this issue specifically.

Le jeu. 11 avr. 2024, 16:48, Originalimoc @.***> a écrit :

"completely blown out highlights". Your client is not setup correctly. HDR not enabled?

I don't know, I don't have an HDR monitor on either side. On Macos there's no setting for it, as far as I know?

I have no Mac but MacOS ver has no this? If so I guess due to different Graphical API it's not implemented yet. image.png (view on web) https://github.com/moonlight-stream/moonlight-qt/assets/20218140/e17a7708-be83-479d-ac2a-3fe2ff940f21

— Reply to this email directly, view it on GitHub https://github.com/moonlight-stream/moonlight-qt/issues/1213#issuecomment-2049868851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVYVBTO74VQEJHQCU4VCKTY42PCPAVCNFSM6AAAAABETY4DY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZHA3DQOBVGE . You are receiving this because you commented.Message ID: @.***>

stfm1973 commented 3 months ago

Right, sorry, I thought you meant in MacOS.

It looks like this when HDR is enabled in Moonlight, even after several relaunches: Skärmavbild 2024-04-15 kl  09 07 38

stfm1973 commented 3 months ago

All of a sudden it looked like this... better, but still much worse than without hdr. Wide gamut is still not working at all.

Skärmavbild 2024-04-15 kl  09 13 50