search

moonlight-stream / moonlight-qt

GameStream client for PCs (Windows, Mac, Linux, and Steam Link)
GNU General Public License v3.0
10.71k stars 627 forks source link

Custom Resolutions not displaying correctly V6.0.0 MacOS #1301

Closed HankHill121 closed 4 months ago

HankHill121 commented 5 months ago

Describe the bug Custom Resolutions used on previous versions of Moonlight now give black bars when they previously filled the entire screen. In version 5.0.1 and before I used the custom resolution of 2624x1696 and set the display mode to fullscreen which would display the image using my entire screen, including the notch area. In v5.0.1 If I set the display mode to borderless windowed then I would get black bars like in v6.0.0. Now in v6.0.0 I get black bars on the top and bottom of my screen no matter if its set to fullscreen or borderless windowed when using custom resolutions.

The resolution on the host pc is set to 2624x1696 on a virtual monitor.

Steps to reproduce Just set the custom resolution and connect.

Affected games Everything is affected.

Other Moonlight clients

Client PC details (please complete the following information)

Server PC details (please complete the following information)

Moonlight Logs (please attach) Moonlight-1717687990.log

TsaiTung-Chen commented 4 months ago

Similar issue here. In the previous v5.0.1 version, the image looks blurry in borderless mode but clear in fullscreen mode. But now in the v6.0.0 version, they look the same; the image looks blurry in both borderless mode and fullscreen mode. So I temporarily switch back to the old v5.0.1 version.

BTW, I'm using BetteryDisplay to apply a custom HiDPI which makes the UI look like 1680x945 on my 2560x1440 display. And the resolution setting I use in Moonlight is 2560x1440.

cgutman commented 4 months ago

This build should resolve the issue: https://ci.appveyor.com/project/cgutman/moonlight-qt/builds/49983730/job/84mb5cv3d64jkg68/artifacts

For @TsaiTung-Chen, I'm unsure if yours will be resolved, because I'm not sure how exactly BetteryDisplay is working and whether it would interfere with native 2560x1440 rendering in applications. We've moved away from forcing display mode setting in macOS due to many reports of OS hangs, crashes, and other nasty things. In the case that your workflow depends on Moonlight actually forcing a display mode that overrides what BetteryDisplay is doing, you can set the I_WANT_BUGGY_FULLSCREEN=1 environment variable using the new build to get the old pre-6.0 fullscreen behavior.

Let me know if this resolves everything.

TsaiTung-Chen commented 4 months ago

you can set the I_WANT_BUGGY_FULLSCREEN=1 environment variable using the new build to get the old pre-6.0 fullscreen behavior.

I have added this environment variable to the info.plist in the Moonlight bundle, and it works well.

Thank you @cgutman 👍

LetrixZ commented 4 months ago

This build should resolve the issue: https://ci.appveyor.com/project/cgutman/moonlight-qt/builds/49983730/job/84mb5cv3d64jkg68/artifacts

For @TsaiTung-Chen, I'm unsure if yours will be resolved, because I'm not sure how exactly BetteryDisplay is working and whether it would interfere with native 2560x1440 rendering in applications. We've moved away from forcing display mode setting in macOS due to many reports of OS hangs, crashes, and other nasty things. In the case that your workflow depends on Moonlight actually forcing a display mode that overrides what BetteryDisplay is doing, you can set the I_WANT_BUGGY_FULLSCREEN=1 environment variable using the new build to get the old pre-6.0 fullscreen behavior.

Let me know if this resolves everything.

I can't download this. 

{"message":"Artifacts download limit (1024 MB/day) exceeded."}

Tried with r2493 (latest build) and this environment variable but still have this issue. Using 5.0.1 in the meantime.