search

moonlight-stream / moonlight-qt

GameStream client for PCs (Windows, Mac, Linux, and Steam Link)
GNU General Public License v3.0
10.08k stars 588 forks source link

windows installer needs work #1312

Open 000MDK opened 3 months ago

000MDK commented 3 months ago

Describe the bug your 6.0 release is unusable for me too (reports are already here) and I wanted to go back to 5.0.1. That's when I realised some things about your installer:

  1. need to uninstall to downgrade ("is already installed")
  2. Uninstall deletes user configs without warning (!!!)
  3. Installer can't be unpacked with standard tools (universal extractor, 7-zip)

Steps to reproduce Have 5.0.1 setup and working, update to 6.0, uninstall 6.0, reinstall 5.0.1 -> experience frustration

cgutman commented 3 months ago

your 6.0 release is unusable for me too (reports are already here) and I wanted to go back to 5.0.1.

Which issue number? I see only 1 issued reported here on Windows with v6.0.0 by 1 user, so I certainly don't see any widespread issues such that I would know what problem you are refererring to.

That's when I realised some things about your installer:

Yeah, I agree 1 & 2 are problems. Unfortunately, 1 is difficult to fix because it's Windows Installer itself that enforces that package versions cannot go backwards. 2 might be solvable with a checkbox in the uninstall/modify page and an MSI property.

For 3, we provide premade portable zips if you just want the Moonlight binaries themselves.

000MDK commented 2 months ago

you can have msi-installers perform downgrades, you have to define a custom upgrade for this (VersionMin = ProductVersion, VersionMax = nil, attributes column 0 or 1025)

.. I did not find your installer files so far, or I would have answered including a PR, would be great to also fix this not only nag ;)

for 3, I wrongfully assumed you have a special portable build and not the same exe, that's on me for sure

cgutman commented 2 months ago

you can have msi-installers perform downgrades, you have to define a custom upgrade for this (VersionMin = ProductVersion, VersionMax = nil, attributes column 0 or 1025)

Oh neat, I didn't know that was possible.

.. I did not find your installer files so far, or I would have answered including a PR, would be great to also fix this not only nag ;)

They are in the wix folder. The MSI is in wix\Moonlight\Product.wxs and the bundle EXE is in wix\MoonlightSetup\Bundle.wxs

https://github.com/moonlight-stream/moonlight-qt/tree/master/wix

000MDK commented 2 months ago

for wix it's just a setting to allow downgrades (default is no; might not work for bundles), but i rather make a staging env for this and test the implications for userdata (guess: will be deleted on downgrades) - a PR is on my list for next week, keeping you posted here